From patchwork Fri Jun 19 14:33:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191216 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp609887ilo; Fri, 19 Jun 2020 08:04:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZJSv8XtdLxrf4a8E17rX0vx7ls/QH+ZgJe547gClcFhGfntU6l/frw9N20m9utx/NPu/R X-Received: by 2002:a17:907:217a:: with SMTP id rl26mr3903874ejb.209.1592579085414; Fri, 19 Jun 2020 08:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592579085; cv=none; d=google.com; s=arc-20160816; b=F0l47H6VtvJ4MNUV04c0acdLvkgNTxWXGEPqooRN1QV1ty1IZajhJ3NY2I3Ol3bC3I H7zSjIW5AkO0a0bVdO3ayY/2xjaTS1DvHLVUki8kbLrfLH8EbNOjcOS0kq9fdXag81Cz u2/vYVRjaRRy0G7TwyHrLYB2y0YB9nLfAC8pifaXjXTNwVMwoXL9pCftIETQ85zlhFch LUvoTnNsjbuZpZFpM/yCsPyZjlmi9uPeZfTsFUVM27I3DiwQbAhCg7l7B0DmBOK08sJC UaD2wB3bRri8CPIUGarveITmOTzXmZrTX/RfD4rBmuO0KwVSYcIzglFToIdpKGY4LN2M TFxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kb5mkcI0QA9VSWvPHfo3mdWVHBjZYAxjT/YAnnPcaJc=; b=cJc9TTyYzb3G/YVlny+FflF2jVXggomssFuEZq/kkBV1N3R1qfXmhjdMqig4e+mCrm LThIIGr5WD3T+Thz1k+T9/Atb0f+2r6ShOATT0N9akO4ytrsuqlfLyGeBP6Knx8V3SUH 6l+t7UG4bj+AwHyX/ZnFMway6IIONjXOnJqezNzfc2LDNU/cmFyeu5JcptXaVb2dN3ES 9PdotgalBmdQhosaw+GkBzKhxXQ9ZYf/bPpeQ9EErfRn6jcyATir0PLW/Ld3EHVMRLtl 5ZM0iy558WjykZviRc7Rq2RWf2EHP2+RBpegFK2JVjLpEisrrCBCkEP3NqJW2ICUyYEq 6FLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Uqbou9Dd; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si4430741ejj.111.2020.06.19.08.04.45; Fri, 19 Jun 2020 08:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Uqbou9Dd; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390711AbgFSPEo (ORCPT + 15 others); Fri, 19 Jun 2020 11:04:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:33400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391179AbgFSPEm (ORCPT ); Fri, 19 Jun 2020 11:04:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AC1D21841; Fri, 19 Jun 2020 15:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579082; bh=X+fYMIqv9aW3zx9EKxEdSSMi/yaBPVv4khSCIkS3DbA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uqbou9Dddl3JSCMDZGEQid9VI1kqp/2a4CFqS6EOB/zzFPBiCbxNuUVea2MiUBRj7 oMdzrTGk28MiXmThvT/6OBEpE4gXQy18IcJ32xyz+ScwwdSbtVxun+Pn6sxqU537Q6 qVBk5ZCK/MdbyK1cnTd8KSKW26vQkoq5V2HIdswg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH 4.19 252/267] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensors bus Date: Fri, 19 Jun 2020 16:33:57 +0200 Message-Id: <20200619141700.760834318@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141648.840376470@linuxfoundation.org> References: <20200619141648.840376470@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski commit 8807d356bfea92b0a8f04ce421800ed83400cd22 upstream. GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted polarity. This bug has been there since adding the CM36651 sensor by commit 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2"), but went unnoticed because the "i2c-gpio" driver ignored the GPIO polarity specified in the device-tree. The recent conversion of "i2c-gpio" driver to the new, descriptor based GPIO API, automatically made it the DT-specified polarity aware, what broke the CM36651 sensor operation. Fixes: 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2") CC: stable@vger.kernel.org # 4.16+ Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi @@ -50,7 +50,7 @@ i2c_cm36651: i2c-gpio-2 { compatible = "i2c-gpio"; - gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>; + gpios = <&gpf0 0 GPIO_ACTIVE_HIGH>, <&gpf0 1 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; #address-cells = <1>; #size-cells = <0>;