| Message ID | b3ef5357898c06aaccb2fcbaee4ef91a3d0fd7bb.1376486713.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Wed, Aug 14, 2013 at 7:02 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote: > Many common initializations of struct policy are moved to core now and hence > this driver doesn't need to do it. This patch removes such code. > > Most recent of those changes is to call ->get() in the core after calling > ->init(). > > Cc: Kukjin Kim <kgene.kim@samsung.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> This consolidation work looks fine, Acked-By: Amit Daniel Kachhap <amit.daniel@samsung.com> Thanks, Amit > --- > drivers/cpufreq/exynos-cpufreq.c | 2 -- > drivers/cpufreq/exynos5440-cpufreq.c | 1 - > 2 files changed, 3 deletions(-) > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c > index 79b869b..b1db082 100644 > --- a/drivers/cpufreq/exynos-cpufreq.c > +++ b/drivers/cpufreq/exynos-cpufreq.c > @@ -226,8 +226,6 @@ static struct notifier_block exynos_cpufreq_nb = { > > static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > { > - policy->cur = policy->min = policy->max = exynos_getspeed(policy->cpu); > - > /* set the transition latency value */ > policy->cpuinfo.transition_latency = 100000; > > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c > index 9a5ed485..91a64d6 100644 > --- a/drivers/cpufreq/exynos5440-cpufreq.c > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > @@ -316,7 +316,6 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > return ret; > } > > - policy->cur = dvfs_info->cur_frequency; > policy->cpuinfo.transition_latency = dvfs_info->latency; > cpumask_setall(policy->cpus); > > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
amit daniel kachhap wrote: > > On Wed, Aug 14, 2013 at 7:02 PM, Viresh Kumar <viresh.kumar@linaro.org> > wrote: > > Many common initializations of struct policy are moved to core now and > hence > > this driver doesn't need to do it. This patch removes such code. > > > > Most recent of those changes is to call ->get() in the core after > calling > > ->init(). > > > > Cc: Kukjin Kim <kgene.kim@samsung.com> Acked-by: Kukjin Kim <kgene.kim@samsung.com> Thanks, Kukjin > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > This consolidation work looks fine, > Acked-By: Amit Daniel Kachhap <amit.daniel@samsung.com> > > Thanks, > Amit > > --- > > drivers/cpufreq/exynos-cpufreq.c | 2 -- > > drivers/cpufreq/exynos5440-cpufreq.c | 1 - > > 2 files changed, 3 deletions(-) > > > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos- > cpufreq.c > > index 79b869b..b1db082 100644 > > --- a/drivers/cpufreq/exynos-cpufreq.c > > +++ b/drivers/cpufreq/exynos-cpufreq.c > > @@ -226,8 +226,6 @@ static struct notifier_block exynos_cpufreq_nb = { > > > > static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > > { > > - policy->cur = policy->min = policy->max = exynos_getspeed(policy- > >cpu); > > - > > /* set the transition latency value */ > > policy->cpuinfo.transition_latency = 100000; > > > > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c > b/drivers/cpufreq/exynos5440-cpufreq.c > > index 9a5ed485..91a64d6 100644 > > --- a/drivers/cpufreq/exynos5440-cpufreq.c > > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > > @@ -316,7 +316,6 @@ static int exynos_cpufreq_cpu_init(struct > cpufreq_policy *policy) > > return ret; > > } > > > > - policy->cur = dvfs_info->cur_frequency; > > policy->cpuinfo.transition_latency = dvfs_info->latency; > > cpumask_setall(policy->cpus); > > > > -- > > 1.7.12.rc2.18.g61b472e
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 79b869b..b1db082 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -226,8 +226,6 @@ static struct notifier_block exynos_cpufreq_nb = { static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) { - policy->cur = policy->min = policy->max = exynos_getspeed(policy->cpu); - /* set the transition latency value */ policy->cpuinfo.transition_latency = 100000; diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c index 9a5ed485..91a64d6 100644 --- a/drivers/cpufreq/exynos5440-cpufreq.c +++ b/drivers/cpufreq/exynos5440-cpufreq.c @@ -316,7 +316,6 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) return ret; } - policy->cur = dvfs_info->cur_frequency; policy->cpuinfo.transition_latency = dvfs_info->latency; cpumask_setall(policy->cpus);
Many common initializations of struct policy are moved to core now and hence this driver doesn't need to do it. This patch removes such code. Most recent of those changes is to call ->get() in the core after calling ->init(). Cc: Kukjin Kim <kgene.kim@samsung.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/exynos-cpufreq.c | 2 -- drivers/cpufreq/exynos5440-cpufreq.c | 1 - 2 files changed, 3 deletions(-)