| Message ID | 20200620042140.42070-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/s390x: Fix SQXBR | expand |
On 20.06.20 06:21, Richard Henderson wrote: > The output is 128-bit, and thus requires a pair of 64-bit temps. > > Buglink: https://bugs.launchpad.net/bugs/1883984 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/insn-data.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def > index 91ddaedd84..d79ae9e3f1 100644 > --- a/target/s390x/insn-data.def > +++ b/target/s390x/insn-data.def > @@ -798,7 +798,7 @@ > /* SQUARE ROOT */ > F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP) > F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP) > - F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP) > + F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP) > F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP) > F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP) > > Reviewed-by: David Hildenbrand <david@redhat.com> -- Thanks, David / dhildenb
On Fri, 19 Jun 2020 21:21:40 -0700 Richard Henderson <richard.henderson@linaro.org> wrote: > The output is 128-bit, and thus requires a pair of 64-bit temps. > > Buglink: https://bugs.launchpad.net/bugs/1883984 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/s390x/insn-data.def | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def > index 91ddaedd84..d79ae9e3f1 100644 > --- a/target/s390x/insn-data.def > +++ b/target/s390x/insn-data.def > @@ -798,7 +798,7 @@ > /* SQUARE ROOT */ > F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP) > F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP) > - F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP) > + F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP) > F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP) > F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP) > Thanks, applied.
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 91ddaedd84..d79ae9e3f1 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -798,7 +798,7 @@ /* SQUARE ROOT */ F(0xb314, SQEBR, RRE, Z, 0, e2, new, e1, sqeb, 0, IF_BFP) F(0xb315, SQDBR, RRE, Z, 0, f2, new, f1, sqdb, 0, IF_BFP) - F(0xb316, SQXBR, RRE, Z, x2h, x2l, new, x1, sqxb, 0, IF_BFP) + F(0xb316, SQXBR, RRE, Z, x2h, x2l, new_P, x1, sqxb, 0, IF_BFP) F(0xed14, SQEB, RXE, Z, 0, m2_32u, new, e1, sqeb, 0, IF_BFP) F(0xed15, SQDB, RXE, Z, 0, m2_64, new, f1, sqdb, 0, IF_BFP)
The output is 128-bit, and thus requires a pair of 64-bit temps. Buglink: https://bugs.launchpad.net/bugs/1883984 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/s390x/insn-data.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1