diff mbox series

[v1,13/18] tests/docker: check for an parameters not empty string

Message ID 20200622143204.12921-14-alex.bennee@linaro.org
State Superseded
Headers show
Series testing/next (vm, gitlab) | expand

Commit Message

Alex Bennée June 22, 2020, 2:31 p.m. UTC 
Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/docker/common.rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Eric Blake June 29, 2020, 4:15 p.m. UTC | #1 
On 6/22/20 9:31 AM, Alex Bennée wrote:
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   tests/docker/common.rc | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/tests/docker/common.rc b/tests/docker/common.rc

> index 02cd67a8c5e..b27ce17e333 100755

> --- a/tests/docker/common.rc

> +++ b/tests/docker/common.rc

> @@ -47,7 +47,7 @@ build_qemu()

>   check_qemu()

>   {

>       # default to make check unless the caller specifies

> -    if test -z "$@"; then

> +    if [ $# == 0 ]; then


This is a bashism, but in a file marked #!/bin/sh.  You need to spell it 
= instead of ==.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org
diff mbox series

Patch

diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 02cd67a8c5e..b27ce17e333 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -47,7 +47,7 @@  build_qemu()
 check_qemu()
 {
     # default to make check unless the caller specifies
-    if test -z "$@"; then
+    if [ $# == 0 ]; then
         INVOCATION="check"
     else
         INVOCATION="$@"