From patchwork Tue Jun 23 19:36:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 191538 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp2291589ile; Tue, 23 Jun 2020 13:05:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRL6Q7SbvWeP3Dwjd7ysZ2CmoosRLASeY6r6W/NWGckWB/gwMCYRo2eIAUJyJ7nNFDI4qp X-Received: by 2002:a25:abd2:: with SMTP id v76mr12329831ybi.111.1592942716930; Tue, 23 Jun 2020 13:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592942716; cv=none; d=google.com; s=arc-20160816; b=faEZh57yvACdgHAkSFUGQi9apgbPq8LOkVo5qnJusygiWnkorfXL/iDtB8WlsQjaCR QGC9LiTVCpTGhaukbagU8cH5Qi13/m0Qi9t00pV7m1akkFSNQWdrKYwFX44a1R0/SsNC XS0LVkYvq51Gr6aaQ4G2G7wns26nKh0aQJS5EYhk+Z5NYu2nKb56A4BQ7stKlHy67gxR q5Nz0oKyzr7Vh+DQmmcIuh6H5KXcaIEWLGw6SIjmyVE9pjQ8vry1v8IVWtih0cjq7D6H xaCDZB48mWIuDi4OlpUNhrclpPpiBMucdJSlrLUsYgJzKtn1ovyfaJcvv2AKG965xdPv 3A4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=SDD847ond76J9XGL5A29cRd+o3rpRZsV5UU2znfqmjI=; b=0XF0d4FDqYL/YU5LR+BKIzY6MaoxU+o2CfjPYUIHVugpm5J4Fp/9MWWjoBkJJHC7r8 gRfJsRxxiTGGsgGbUBFEUFS8chHB0TE6DB9ZqE2cpA+3qdHP2nfIs1zzrT2ondID7H/O pm9Usmu/0/8TGwxJsNxHZAPFCrvbsoGjQV1G2vZDWDXYsAj1XO6FU3FDY6jKyItM7+Iy OQ3ljyk4meQcPXqRgtWZzxDciqAofR6Tm/wUUzURtUUUnXHGTTwsT/eu2174iV6n1Kwo jsQWvq7sm74uPGUWBba0kAy6kBBXU2jxIIq7j8/lOK/kehIxxlSuoS4XWLGRLEBRA5PW 08yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FAipURx3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l7si17411950ybb.38.2020.06.23.13.05.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jun 2020 13:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=FAipURx3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:40748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnpAS-0002vf-CW for patch@linaro.org; Tue, 23 Jun 2020 16:05:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnojr-0004gf-N8 for qemu-devel@nongnu.org; Tue, 23 Jun 2020 15:37:47 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:34785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnojp-0005r8-3v for qemu-devel@nongnu.org; Tue, 23 Jun 2020 15:37:47 -0400 Received: by mail-pf1-x443.google.com with SMTP id z63so10571843pfb.1 for ; Tue, 23 Jun 2020 12:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SDD847ond76J9XGL5A29cRd+o3rpRZsV5UU2znfqmjI=; b=FAipURx3opxuS5QOjkETUoEEAZDBqFgjjCdMSYWZIKcz7hy4p7wyqt50wqZNYJwvoH TPJQ+TbzM72E/8nHmdX4xblHnQmrt30kb98r34zDxv8AuvHUWjZlYPdkYlkX/SaapZyn dpTG8PjCqCTO7cZRgEi1zDNrnDS61DrgqpF6k0tSuqdVRwZR3ehQtieA1GrVxaXYOytG mI723qM8CNPYVKRLbfjo/powfJ6LkamP54otVfSyhjQAzp+YzVYQHfnjzvfHLNfsCiiG wuHPUcEMbHnnTHwnir05eAfOU9Q4BlytgHU9aOgOLhjm379/Oo9Xs5VXFk9gYuqtBpcY UMcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SDD847ond76J9XGL5A29cRd+o3rpRZsV5UU2znfqmjI=; b=WeXLoHhkElWzRI1o9Y1Sx7QXEZ8sOJFu12a4sur87ZIvHpuWbBrixGlsIGBWRAIJRY 7Nl3cxbKkab1GE3V0pQSPpzVC+jXuysT0x/oVI3acEC+nAfYrbTQN3M5onoEWatIOlVk etvkHVq99FU/yatOW6HXoKlRGdurn/gyrf5R6mhsfColfdt2mcjNRx5wvO6HkSLnxjLR moLjS1zO+6HLlMXLYpWSg+VPVeDLMeh+utqJxtl776IQddZtn8ou6ho8nlE85auGzSTi pVW0I7MRw3U6DExA/7w0lC8i0yVUL32TzQvkRYOXFeToJxAIznL7/F51hFsqMuJT5wyf JjIw== X-Gm-Message-State: AOAM531IjrWFJlzwz15zLtc6Ks+oCI+sIz3pd2K871FjBAdYX1kk1eTn qBNY6BSbbOw8ADvn3rzcQ6134mzo8ac= X-Received: by 2002:aa7:9d9a:: with SMTP id f26mr25575927pfq.229.1592941063433; Tue, 23 Jun 2020 12:37:43 -0700 (PDT) Received: from localhost.localdomain (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id p12sm17927642pfq.69.2020.06.23.12.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 12:37:42 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v8 31/45] target/arm: Tidy trans_LD1R_zpri Date: Tue, 23 Jun 2020 12:36:44 -0700 Message-Id: <20200623193658.623279-32-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200623193658.623279-1-richard.henderson@linaro.org> References: <20200623193658.623279-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, david.spickett@linaro.org, steplong@quicinc.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Move the variable declarations to the top of the function, but do not create a new label before sve_access_check. Signed-off-by: Richard Henderson --- v8: Split out from previous patch (pmm). --- target/arm/translate-sve.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) -- 2.25.1 Reviewed-by: Peter Maydell diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 4fa521989d..a3a0b98fbc 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -4883,17 +4883,19 @@ static bool trans_LD1RQ_zpri(DisasContext *s, arg_rpri_load *a) /* Load and broadcast element. */ static bool trans_LD1R_zpri(DisasContext *s, arg_rpri_load *a) { - if (!sve_access_check(s)) { - return true; - } - unsigned vsz = vec_full_reg_size(s); unsigned psz = pred_full_reg_size(s); unsigned esz = dtype_esz[a->dtype]; unsigned msz = dtype_msz(a->dtype); - TCGLabel *over = gen_new_label(); + TCGLabel *over; TCGv_i64 temp, clean_addr; + if (!sve_access_check(s)) { + return true; + } + + over = gen_new_label(); + /* If the guarding predicate has no bits set, no load occurs. */ if (psz <= 8) { /* Reduce the pred_esz_masks value simply to reduce the