From patchwork Wed Jun 24 22:06:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 191713 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp240054ilg; Wed, 24 Jun 2020 15:06:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaz2Tl4bu4Nc8PycwC0uKU8MeIOgE4ejt2Kp6DQZlfUKD1gMPUOWRd5OOYphAnM+tg7pW5 X-Received: by 2002:a05:6402:1ca2:: with SMTP id cz2mr27637774edb.15.1593036383942; Wed, 24 Jun 2020 15:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593036383; cv=none; d=google.com; s=arc-20160816; b=ZBSMo1QMZa4w1GwowErJY4dhFyFNz7MKI5vlQJZKG/aiWNBXxML37Uq11VPEmKXghH CyU0iQ+NSQ8Dyy0H4wQ7TwYjsK2BrQXtBPsYb74qUPgbNAew0RS5aYcjFgRHJI03ACje 65wewbQnIsI3KOzB6TKj2V9aHFiuVbAsDFpWEnqDfbcp3Kd1DLWSP7bpRNpKHjUazEAr qbZ7DUFv0QVdL4va9CxxJkYprw4yCygh8VhoAr4ag8n01HG2uErE7LvHhN3bUhaAYRRj UIS9pzv9vu8tCFEH6bqsa/dZwWMsVhn5HwVLVdr3+bh8GIjFZ37xNPr9oPycSC93s5gr PBbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nVI3tNFYc9VW8T9pdAkjbyo2Sl/Gt6ztcx6TyFnW4Zw=; b=hcXcEdCqwzWjeVpfNWB+f6BQvBrgRGeHi3DVGakMesntHwmm8eONUGHLd2Y6+UhW0P P9kqEyXvQ2oQl33ZJu5QWoGmrsEERITa6VOt1IQeT0eKEr3Z1tIX6nr8vwJHCNQpdssy 5DfSElLuerObC/GDFp+Ne4M+nby4tVt/MVGCoeYVkOKBklYzQDmNhx5/MVtYXm99dsjh aWmHGJp9FoQ71OVVEJnFdi+UI0MmJgr0e+vkayTL+BF32Jq7Gqg569Rc4Dzquy4Js9uO 7OdLgXF2mnse8lErovEBd22tslD7h8finx3EN50QceQ8o/H2hvszVwzaDsbX4KvKKxfz Cz5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=fIQ1mC3J; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca21si6832787edb.533.2020.06.24.15.06.23; Wed, 24 Jun 2020 15:06:23 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=fIQ1mC3J; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389513AbgFXWGW (ORCPT + 9 others); Wed, 24 Jun 2020 18:06:22 -0400 Received: from mail.zx2c4.com ([192.95.5.64]:37289 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389453AbgFXWGT (ORCPT ); Wed, 24 Jun 2020 18:06:19 -0400 Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 21483d94; Wed, 24 Jun 2020 21:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=mail; bh=PMSW1JxYMnQhk8qd60Y9kOgVp eM=; b=fIQ1mC3JvgjY9VSaMhXmHUV/x6zWN8RCPRM99WCTZRw4KZdCNuJAt0YJq i4hzHZ4C3giwOSudSZOotsyoVmi57FpEZCymmrqp11smg5AwPSLe1uI+D0Rzfvq4 Zxlmkdw/b3c82Az5rcBmdEuyh8Dayk5LTnguC2EEGfSPiGPybyOkQK4iSKtKRS/6 qaVmcJvAd/65icLDLpVGEOgOvZrEBWY3w9F1+yYuoTmdTc+pQDyxGAYI1K3lpvDM A2nD6zPUKS0tgNVka6RZyCgn2W4TrqQOhTV+6N6TkY3bm8u4Ls03CGUcLBWoQOXH 7mL/aID0K4zyqB8S6pCfWYiQfEm1w== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 557d7f39 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 24 Jun 2020 21:47:13 +0000 (UTC) From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, davem@davemloft.net Cc: "Jason A. Donenfeld" Subject: [PATCH net 3/4] hns: do not cast return value of napi_gro_receive to null Date: Wed, 24 Jun 2020 16:06:05 -0600 Message-Id: <20200624220606.1390542-4-Jason@zx2c4.com> In-Reply-To: <20200624220606.1390542-1-Jason@zx2c4.com> References: <20200624220606.1390542-1-Jason@zx2c4.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Basically no drivers care about the return value here, and there's no __must_check that would make casting to void sensible, so remove it. Signed-off-by: Jason A. Donenfeld --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.27.0 diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c index c117074c16e3..23f278e46975 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c @@ -699,7 +699,7 @@ static void hns_nic_rx_up_pro(struct hns_nic_ring_data *ring_data, struct net_device *ndev = ring_data->napi.dev; skb->protocol = eth_type_trans(skb, ndev); - (void)napi_gro_receive(&ring_data->napi, skb); + napi_gro_receive(&ring_data->napi, skb); } static int hns_desc_unused(struct hnae_ring *ring)