| Message ID | 20200628214230.2592-2-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hw/arm/palm.c: Fix Coverity issue CID 1421944 | expand |
Peter Maydell <peter.maydell@linaro.org> 于2020年6月29日周一 上午5:45写道： > > Remove hard-tabs from palm.c. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Li Qiang <liq3ea@gmail.com> > --- > hw/arm/palm.c | 64 +++++++++++++++++++++++++-------------------------- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/hw/arm/palm.c b/hw/arm/palm.c > index 97ca105d297..569836178f6 100644 > --- a/hw/arm/palm.c > +++ b/hw/arm/palm.c > @@ -61,21 +61,21 @@ static const MemoryRegionOps static_ops = { > /* Palm Tunsgten|E support */ > > /* Shared GPIOs */ > -#define PALMTE_USBDETECT_GPIO 0 > -#define PALMTE_USB_OR_DC_GPIO 1 > -#define PALMTE_TSC_GPIO 4 > -#define PALMTE_PINTDAV_GPIO 6 > -#define PALMTE_MMC_WP_GPIO 8 > -#define PALMTE_MMC_POWER_GPIO 9 > -#define PALMTE_HDQ_GPIO 11 > -#define PALMTE_HEADPHONES_GPIO 14 > -#define PALMTE_SPEAKER_GPIO 15 > +#define PALMTE_USBDETECT_GPIO 0 > +#define PALMTE_USB_OR_DC_GPIO 1 > +#define PALMTE_TSC_GPIO 4 > +#define PALMTE_PINTDAV_GPIO 6 > +#define PALMTE_MMC_WP_GPIO 8 > +#define PALMTE_MMC_POWER_GPIO 9 > +#define PALMTE_HDQ_GPIO 11 > +#define PALMTE_HEADPHONES_GPIO 14 > +#define PALMTE_SPEAKER_GPIO 15 > /* MPU private GPIOs */ > -#define PALMTE_DC_GPIO 2 > -#define PALMTE_MMC_SWITCH_GPIO 4 > -#define PALMTE_MMC1_GPIO 6 > -#define PALMTE_MMC2_GPIO 7 > -#define PALMTE_MMC3_GPIO 11 > +#define PALMTE_DC_GPIO 2 > +#define PALMTE_MMC_SWITCH_GPIO 4 > +#define PALMTE_MMC1_GPIO 6 > +#define PALMTE_MMC2_GPIO 7 > +#define PALMTE_MMC3_GPIO 11 > > static MouseTransformInfo palmte_pointercal = { > .x = 320, > @@ -100,17 +100,17 @@ static struct { > int column; > } palmte_keymap[0x80] = { > [0 ... 0x7f] = { -1, -1 }, > - [0x3b] = { 0, 0 }, /* F1 -> Calendar */ > - [0x3c] = { 1, 0 }, /* F2 -> Contacts */ > - [0x3d] = { 2, 0 }, /* F3 -> Tasks List */ > - [0x3e] = { 3, 0 }, /* F4 -> Note Pad */ > - [0x01] = { 4, 0 }, /* Esc -> Power */ > - [0x4b] = { 0, 1 }, /* Left */ > - [0x50] = { 1, 1 }, /* Down */ > - [0x48] = { 2, 1 }, /* Up */ > - [0x4d] = { 3, 1 }, /* Right */ > - [0x4c] = { 4, 1 }, /* Centre */ > - [0x39] = { 4, 1 }, /* Spc -> Centre */ > + [0x3b] = { 0, 0 }, /* F1 -> Calendar */ > + [0x3c] = { 1, 0 }, /* F2 -> Contacts */ > + [0x3d] = { 2, 0 }, /* F3 -> Tasks List */ > + [0x3e] = { 3, 0 }, /* F4 -> Note Pad */ > + [0x01] = { 4, 0 }, /* Esc -> Power */ > + [0x4b] = { 0, 1 }, /* Left */ > + [0x50] = { 1, 1 }, /* Down */ > + [0x48] = { 2, 1 }, /* Up */ > + [0x4d] = { 3, 1 }, /* Right */ > + [0x4c] = { 4, 1 }, /* Centre */ > + [0x39] = { 4, 1 }, /* Spc -> Centre */ > }; > > static void palmte_button_event(void *opaque, int keycode) > @@ -161,13 +161,13 @@ static void palmte_gpio_setup(struct omap_mpu_state_s *cpu) > [PALMTE_MMC_SWITCH_GPIO])); > > misc_gpio = qemu_allocate_irqs(palmte_onoff_gpios, cpu, 7); > - qdev_connect_gpio_out(cpu->gpio, PALMTE_MMC_POWER_GPIO, misc_gpio[0]); > - qdev_connect_gpio_out(cpu->gpio, PALMTE_SPEAKER_GPIO, misc_gpio[1]); > - qdev_connect_gpio_out(cpu->gpio, 11, misc_gpio[2]); > - qdev_connect_gpio_out(cpu->gpio, 12, misc_gpio[3]); > - qdev_connect_gpio_out(cpu->gpio, 13, misc_gpio[4]); > - omap_mpuio_out_set(cpu->mpuio, 1, misc_gpio[5]); > - omap_mpuio_out_set(cpu->mpuio, 3, misc_gpio[6]); > + qdev_connect_gpio_out(cpu->gpio, PALMTE_MMC_POWER_GPIO, misc_gpio[0]); > + qdev_connect_gpio_out(cpu->gpio, PALMTE_SPEAKER_GPIO, misc_gpio[1]); > + qdev_connect_gpio_out(cpu->gpio, 11, misc_gpio[2]); > + qdev_connect_gpio_out(cpu->gpio, 12, misc_gpio[3]); > + qdev_connect_gpio_out(cpu->gpio, 13, misc_gpio[4]); > + omap_mpuio_out_set(cpu->mpuio, 1, misc_gpio[5]); > + omap_mpuio_out_set(cpu->mpuio, 3, misc_gpio[6]); > > /* Reset some inputs to initial state. */ > qemu_irq_lower(qdev_get_gpio_in(cpu->gpio, PALMTE_USBDETECT_GPIO)); > -- > 2.20.1 > >
On 6/28/20 11:42 PM, Peter Maydell wrote: > Remove hard-tabs from palm.c. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/arm/palm.c | 64 +++++++++++++++++++++++++-------------------------- > 1 file changed, 32 insertions(+), 32 deletions(-) Using 'git-diff -w': Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 97ca105d297..569836178f6 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -61,21 +61,21 @@ static const MemoryRegionOps static_ops = { /* Palm Tunsgten|E support */ /* Shared GPIOs */ -#define PALMTE_USBDETECT_GPIO 0 -#define PALMTE_USB_OR_DC_GPIO 1 -#define PALMTE_TSC_GPIO 4 -#define PALMTE_PINTDAV_GPIO 6 -#define PALMTE_MMC_WP_GPIO 8 -#define PALMTE_MMC_POWER_GPIO 9 -#define PALMTE_HDQ_GPIO 11 -#define PALMTE_HEADPHONES_GPIO 14 -#define PALMTE_SPEAKER_GPIO 15 +#define PALMTE_USBDETECT_GPIO 0 +#define PALMTE_USB_OR_DC_GPIO 1 +#define PALMTE_TSC_GPIO 4 +#define PALMTE_PINTDAV_GPIO 6 +#define PALMTE_MMC_WP_GPIO 8 +#define PALMTE_MMC_POWER_GPIO 9 +#define PALMTE_HDQ_GPIO 11 +#define PALMTE_HEADPHONES_GPIO 14 +#define PALMTE_SPEAKER_GPIO 15 /* MPU private GPIOs */ -#define PALMTE_DC_GPIO 2 -#define PALMTE_MMC_SWITCH_GPIO 4 -#define PALMTE_MMC1_GPIO 6 -#define PALMTE_MMC2_GPIO 7 -#define PALMTE_MMC3_GPIO 11 +#define PALMTE_DC_GPIO 2 +#define PALMTE_MMC_SWITCH_GPIO 4 +#define PALMTE_MMC1_GPIO 6 +#define PALMTE_MMC2_GPIO 7 +#define PALMTE_MMC3_GPIO 11 static MouseTransformInfo palmte_pointercal = { .x = 320, @@ -100,17 +100,17 @@ static struct { int column; } palmte_keymap[0x80] = { [0 ... 0x7f] = { -1, -1 }, - [0x3b] = { 0, 0 }, /* F1 -> Calendar */ - [0x3c] = { 1, 0 }, /* F2 -> Contacts */ - [0x3d] = { 2, 0 }, /* F3 -> Tasks List */ - [0x3e] = { 3, 0 }, /* F4 -> Note Pad */ - [0x01] = { 4, 0 }, /* Esc -> Power */ - [0x4b] = { 0, 1 }, /* Left */ - [0x50] = { 1, 1 }, /* Down */ - [0x48] = { 2, 1 }, /* Up */ - [0x4d] = { 3, 1 }, /* Right */ - [0x4c] = { 4, 1 }, /* Centre */ - [0x39] = { 4, 1 }, /* Spc -> Centre */ + [0x3b] = { 0, 0 }, /* F1 -> Calendar */ + [0x3c] = { 1, 0 }, /* F2 -> Contacts */ + [0x3d] = { 2, 0 }, /* F3 -> Tasks List */ + [0x3e] = { 3, 0 }, /* F4 -> Note Pad */ + [0x01] = { 4, 0 }, /* Esc -> Power */ + [0x4b] = { 0, 1 }, /* Left */ + [0x50] = { 1, 1 }, /* Down */ + [0x48] = { 2, 1 }, /* Up */ + [0x4d] = { 3, 1 }, /* Right */ + [0x4c] = { 4, 1 }, /* Centre */ + [0x39] = { 4, 1 }, /* Spc -> Centre */ }; static void palmte_button_event(void *opaque, int keycode) @@ -161,13 +161,13 @@ static void palmte_gpio_setup(struct omap_mpu_state_s *cpu) [PALMTE_MMC_SWITCH_GPIO])); misc_gpio = qemu_allocate_irqs(palmte_onoff_gpios, cpu, 7); - qdev_connect_gpio_out(cpu->gpio, PALMTE_MMC_POWER_GPIO, misc_gpio[0]); - qdev_connect_gpio_out(cpu->gpio, PALMTE_SPEAKER_GPIO, misc_gpio[1]); - qdev_connect_gpio_out(cpu->gpio, 11, misc_gpio[2]); - qdev_connect_gpio_out(cpu->gpio, 12, misc_gpio[3]); - qdev_connect_gpio_out(cpu->gpio, 13, misc_gpio[4]); - omap_mpuio_out_set(cpu->mpuio, 1, misc_gpio[5]); - omap_mpuio_out_set(cpu->mpuio, 3, misc_gpio[6]); + qdev_connect_gpio_out(cpu->gpio, PALMTE_MMC_POWER_GPIO, misc_gpio[0]); + qdev_connect_gpio_out(cpu->gpio, PALMTE_SPEAKER_GPIO, misc_gpio[1]); + qdev_connect_gpio_out(cpu->gpio, 11, misc_gpio[2]); + qdev_connect_gpio_out(cpu->gpio, 12, misc_gpio[3]); + qdev_connect_gpio_out(cpu->gpio, 13, misc_gpio[4]); + omap_mpuio_out_set(cpu->mpuio, 1, misc_gpio[5]); + omap_mpuio_out_set(cpu->mpuio, 3, misc_gpio[6]); /* Reset some inputs to initial state. */ qemu_irq_lower(qdev_get_gpio_in(cpu->gpio, PALMTE_USBDETECT_GPIO));
Remove hard-tabs from palm.c. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/arm/palm.c | 64 +++++++++++++++++++++++++-------------------------- 1 file changed, 32 insertions(+), 32 deletions(-) -- 2.20.1