udc: lpc32xx: mark local function static

Message ID 20200630115836.1283978-1-arnd@arndb.de
State New
Headers show
Series
  • udc: lpc32xx: mark local function static
Related show

Commit Message

Arnd Bergmann June 30, 2020, 11:58 a.m.
The kernel test robot reports two functions that should be marked
static:

>> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes]

    1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
>> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes]

    1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit
compiler warning") made it possible to build the driver on x86-64.

Fix the warning as suggested.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/usb/gadget/udc/lpc32xx_udc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.27.0

Comments

Vladimir Zapolskiy June 30, 2020, 6:32 p.m. | #1
Hi Arnd, thank you for the patch.

On 6/30/20 2:58 PM, Arnd Bergmann wrote:
> The kernel test robot reports two functions that should be marked

> static:

> 

>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes]

>     1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

>>> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes]

>     1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

> 

> This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit

> compiler warning") made it possible to build the driver on x86-64.

> 

> Fix the warning as suggested.

> 

> Reported-by: kernel test robot <lkp@intel.com>

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Vladimir Zapolskiy <vz@mleia.com>


--
Best wishes,
Vladimir
Arnd Bergmann July 6, 2020, 3:48 p.m. | #2
On Tue, Jun 30, 2020 at 8:32 PM Vladimir Zapolskiy <vz@mleia.com> wrote:
>

> Hi Arnd, thank you for the patch.

>

> On 6/30/20 2:58 PM, Arnd Bergmann wrote:

> > The kernel test robot reports two functions that should be marked

> > static:

> >

> >>> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes]

> >     1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

> >>> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes]

> >     1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)

> >

> > This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit

> > compiler warning") made it possible to build the driver on x86-64.

> >

> > Fix the warning as suggested.

> >

> > Reported-by: kernel test robot <lkp@intel.com>

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> Acked-by: Vladimir Zapolskiy <vz@mleia.com>


Applied to arm/soc branch now.

     Arnd

Patch

diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c
index 465d0b7c6522..4a112670cc6c 100644
--- a/drivers/usb/gadget/udc/lpc32xx_udc.c
+++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
@@ -1926,7 +1926,7 @@  static const struct usb_ep_ops lpc32xx_ep_ops = {
 };
 
 /* Send a ZLP on a non-0 IN EP */
-void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
+static void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
 {
 	/* Clear EP status */
 	udc_clearep_getsts(udc, ep->hwep_num);
@@ -1940,7 +1940,7 @@  void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
  * This function will only be called when a delayed ZLP needs to be sent out
  * after a DMA transfer has filled both buffers.
  */
-void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
+static void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep)
 {
 	u32 epstatus;
 	struct lpc32xx_request *req;