From patchwork Tue Jun 30 11:58:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 192064 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3744718ilg; Tue, 30 Jun 2020 04:59:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEp5pXG4LFm+heiewaxogAoC3101Jsfvb7izWbJt1hrCJgXPgnTNTw7z9pv8fNVFXtqWY2 X-Received: by 2002:a17:906:7212:: with SMTP id m18mr17795634ejk.29.1593518351659; Tue, 30 Jun 2020 04:59:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593518351; cv=none; d=google.com; s=arc-20160816; b=JhhUeffesyM04QlhLsZQ75bwHovgTwX6GXwsBmohTa8NYIw7oh4a9++x8u8aT1dCVx sCaHbTu2wehgoRUwOEPLJgIoolcq+eTxlPR3pAfnoRgc51Frf0KWJrsJmncaME/huM/G rtni49+GcoW3QJqqb+u0JS26+/44biu3PQwFrYvDhy+ba+ImaNgGO7cGkLlP+ZD78qTe xqbCaH3bi/0Tg/8uzYqsxbm5KgGHdwo4XC+dHGy8ug8KLuA+j7azwlnOJcIvK1gdg0dt 0KSXZtMuyYCfD4YPZeTGVzj3aWKuActyKOxpEsol+cu0Bx8fOR5jcYW7I/y4baFVSjg+ EWJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ad2hUdluoWETnyfssnHRWDkYKSCjdjJLyQJz+nAVO3I=; b=wZsV3QLgkR+S3eVuFSJqnneqFhauur7p/vvM6EXNfewpZdxBdxvshuXx1q0smwh4iX yMHD5YNyJkismOCxPkHCWyLY+z1J7pH7Q1hydyEJSQuLNud3WjVqp1nBtyWCzfq+FGjE 8g/zEySArTxeIIx5enVjTLF4DlHm4/XmTYuknDavar+59lsxp2jrUlXjdoyszA8e4nWQ on6pSUYO8fY9nu7wodFNAXbb9VbnIlNwltxswsMnDA6+Ntay0Xy1ZNo9o+c9kEyZDD2G lupEcbvpfxgmw2XwAGdBANLgj9CbfZwoZU8rIcz48ldoj5P9eTRVpjXUhUtPkxqNLrD8 GDTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dj11si1602990edb.279.2020.06.30.04.59.11; Tue, 30 Jun 2020 04:59:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733215AbgF3L7G (ORCPT + 5 others); Tue, 30 Jun 2020 07:59:06 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:57291 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732517AbgF3L7F (ORCPT ); Tue, 30 Jun 2020 07:59:05 -0400 Received: from threadripper.lan ([149.172.98.151]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPA (Nemesis) id 1MQuwR-1jUbpB2phn-00O0Fd; Tue, 30 Jun 2020 13:58:38 +0200 From: Arnd Bergmann To: Felipe Balbi , Greg Kroah-Hartman , Vladimir Zapolskiy , Sylvain Lemieux Cc: Arnd Bergmann , kernel test robot , "Gustavo A. R. Silva" , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] udc: lpc32xx: mark local function static Date: Tue, 30 Jun 2020 13:58:15 +0200 Message-Id: <20200630115836.1283978-1-arnd@arndb.de> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:veseWBWr1h5vpkppXNC/0CmWqCIFH50Srfs8LPsw5xH/JdVmkgX sejJf0abhmbrS9AYLMm/Sj5uVMzCbA4TtKcgK1Unm6zyyDZzCz5wkeySLEDQA8DmnHMeamE hF5MvVdhAXWySGe1eBjylbtP/fYK70Ua/aAp+cCqFh6TasJvTjA0FnncHPzkc86tXVz6YXq VP/TGHYu23YysT8LVNHAA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:7T6V5aSeTAs=:yJ8wghqXSVPKlr7tAlROEt rmI8tWkpNOImq4me4JBuv3h/w5RoAidkAuFxaO0YhclkFqg53dcd7rEj9IyVUpOi9P1gGkfMl Iu52sA7n75Jk8w1dA8BIugJ0XK6kpVwro+lIb3sa9pbFGNDdnhjqbA16ZV+S1ZK4zf9KJ7uI5 tP8djaRtyV/00QsQwjRD6bcnnenifrkflKYgUmJ2GolntzrOAxisySifXcYb1l5ayVQvF+w3p M60Pa5A5XWJwbeF5hL8O6ePVUAmJe9uSjZzTC9Y5GstwoCUltovKdvpwwtWFJoKDOiWJu3Tql pbB9CYn5T4RjN5nSXGElEJ+pvyop9a2zCskD3wiK37CSj+FwMpSiNUNmFOalOEQ32RdO2mXps btMvhvk/r9Fy3K2PBvfcCfHWELIg5tUlztTFaFAQcXyJ347IaOZUufKG2C6yVeXgzoVvHsHg2 CHIKRJS0kroSlZclNQNPbpg+wq04O+/fmC3sPDd7u96/YLon9oDt9dFqLX/xLxbxh9A4t6UDj TxskZ/bhg3kNaZh8UZvJuJgk02ODW1LJfgxktnDQbRfLIl7EpMdLKXGkW7LSMwLYIWcjb72vp YcgSq8qFdzOgujt76GhE1QFk7VeGlbl2dWouO0mi8hNgJqczSm87TSgjYRhkR2avU+izyfyF4 nMmvg7GoqQg04covHnIzI9GM7dvUXiZHcpBJ0EmPi+8v84MysYrhUSgLeg0i3CfPwX/EniiVc bScdziPooi9MX1v3Y8ipQf3zXnQJsmVtxXTyPkcWyYqxArC2h0qwoJFc30JQXlcuewNGzhLUa Ll0SLMtCZ1Xr7dlLy3Mx7gzpg2KDLNAK3eswA7mpRGI3XYv204= Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org The kernel test robot reports two functions that should be marked static: >> drivers/usb/gadget/udc/lpc32xx_udc.c:1928:6: warning: no previous prototype for 'udc_send_in_zlp' [-Wmissing-prototypes] 1928 | void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) >> drivers/usb/gadget/udc/lpc32xx_udc.c:1942:6: warning: no previous prototype for 'udc_handle_eps' [-Wmissing-prototypes] 1942 | void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) This showed up after my commit 792e559e94bc ("udc: lpc32xx: fix 64-bit compiler warning") made it possible to build the driver on x86-64. Fix the warning as suggested. Reported-by: kernel test robot Signed-off-by: Arnd Bergmann --- drivers/usb/gadget/udc/lpc32xx_udc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.27.0 Acked-by: Vladimir Zapolskiy diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index 465d0b7c6522..4a112670cc6c 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -1926,7 +1926,7 @@ static const struct usb_ep_ops lpc32xx_ep_ops = { }; /* Send a ZLP on a non-0 IN EP */ -void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { /* Clear EP status */ udc_clearep_getsts(udc, ep->hwep_num); @@ -1940,7 +1940,7 @@ void udc_send_in_zlp(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) * This function will only be called when a delayed ZLP needs to be sent out * after a DMA transfer has filled both buffers. */ -void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) +static void udc_handle_eps(struct lpc32xx_udc *udc, struct lpc32xx_ep *ep) { u32 epstatus; struct lpc32xx_request *req;