[04/10] gpio: gpio-pmic-eic-sprd: Fix incorrectly named property 'map'

Message ID 20200630133345.2232932-5-lee.jones@linaro.org
State New
Headers show
Series
  • Clean GPIO of W=1 warnings
Related show

Commit Message

Lee Jones June 30, 2020, 1:33 p.m.
A good attempt has been made to properly document 'struct
sprd_pmic_eic', but 'map' has been incorrectly described as
'regmap' since the driver's inception in 2018.

Fixes the following W=1 kernel build warning:

 drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic'

Cc: Orson Zhai <orsonzhai@gmail.com>
Cc: Baolin Wang <baolin.wang7@gmail.com>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.1

Comments

Baolin Wang June 30, 2020, 3:01 p.m. | #1
On Tue, Jun 30, 2020 at 9:33 PM Lee Jones <lee.jones@linaro.org> wrote:
>

> A good attempt has been made to properly document 'struct

> sprd_pmic_eic', but 'map' has been incorrectly described as

> 'regmap' since the driver's inception in 2018.

>

> Fixes the following W=1 kernel build warning:

>

>  drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic'

>

> Cc: Orson Zhai <orsonzhai@gmail.com>

> Cc: Baolin Wang <baolin.wang7@gmail.com>

> Cc: Chunyan Zhang <zhang.lyra@gmail.com>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Looks good to me.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>


> ---

>  drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c

> index 05000cace9b24..9382851905662 100644

> --- a/drivers/gpio/gpio-pmic-eic-sprd.c

> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c

> @@ -48,7 +48,7 @@ enum {

>   * struct sprd_pmic_eic - PMIC EIC controller

>   * @chip: the gpio_chip structure.

>   * @intc: the irq_chip structure.

> - * @regmap: the regmap from the parent device.

> + * @map:  the regmap from the parent device.

>   * @offset: the EIC controller's offset address of the PMIC.

>   * @reg: the array to cache the EIC registers.

>   * @buslock: for bus lock/sync and unlock.

> --

> 2.25.1

>



-- 
Baolin Wang
Linus Walleij July 8, 2020, 7:16 a.m. | #2
On Tue, Jun 30, 2020 at 3:33 PM Lee Jones <lee.jones@linaro.org> wrote:

> A good attempt has been made to properly document 'struct

> sprd_pmic_eic', but 'map' has been incorrectly described as

> 'regmap' since the driver's inception in 2018.

>

> Fixes the following W=1 kernel build warning:

>

>  drivers/gpio/gpio-pmic-eic-sprd.c:65: warning: Function parameter or member 'map' not described in 'sprd_pmic_eic'

>

> Cc: Orson Zhai <orsonzhai@gmail.com>

> Cc: Baolin Wang <baolin.wang7@gmail.com>

> Cc: Chunyan Zhang <zhang.lyra@gmail.com>

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Patch applied!

Yours,
Linus Walleij

Patch

diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index 05000cace9b24..9382851905662 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -48,7 +48,7 @@  enum {
  * struct sprd_pmic_eic - PMIC EIC controller
  * @chip: the gpio_chip structure.
  * @intc: the irq_chip structure.
- * @regmap: the regmap from the parent device.
+ * @map:  the regmap from the parent device.
  * @offset: the EIC controller's offset address of the PMIC.
  * @reg: the array to cache the EIC registers.
  * @buslock: for bus lock/sync and unlock.