[08/15] mmc: host: dw_mmc-exynos: Add kerneldoc descriptions of for 'dev' args

Message ID 20200701124702.908713-9-lee.jones@linaro.org
State New
Headers show
Series
  • Untitled series #28526
Related show

Commit Message

Lee Jones July 1, 2020, 12:46 p.m.
Provide missing documentation for dw_mci_exynos_suspend_noirq() and
dw_mci_exynos_resume_noirq() function headers.

Fixes the following W=1 kernel build warnings:

 drivers/mmc/host/dw_mmc-exynos.c:184: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_suspend_noirq'
 drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_resume_noirq'

Cc: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thomas Abraham <thomas.ab@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>

---
 drivers/mmc/host/dw_mmc-exynos.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.25.1

Comments

Jaehoon Chung July 5, 2020, 11:53 p.m. | #1
On 7/1/20 9:46 PM, Lee Jones wrote:
> Provide missing documentation for dw_mci_exynos_suspend_noirq() and

> dw_mci_exynos_resume_noirq() function headers.

> 

> Fixes the following W=1 kernel build warnings:

> 

>  drivers/mmc/host/dw_mmc-exynos.c:184: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_suspend_noirq'

>  drivers/mmc/host/dw_mmc-exynos.c:200: warning: Function parameter or member 'dev' not described in 'dw_mci_exynos_resume_noirq'

> 

> Cc: Jaehoon Chung <jh80.chung@samsung.com>

> Cc: Kukjin Kim <kgene@kernel.org>

> Cc: Krzysztof Kozlowski <krzk@kernel.org>

> Cc: Thomas Abraham <thomas.ab@samsung.com>

> Cc: linux-samsung-soc@vger.kernel.org

> Signed-off-by: Lee Jones <lee.jones@linaro.org>


Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>


> ---

>  drivers/mmc/host/dw_mmc-exynos.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c

> index 5e3d95b636769..bd59186f59b39 100644

> --- a/drivers/mmc/host/dw_mmc-exynos.c

> +++ b/drivers/mmc/host/dw_mmc-exynos.c

> @@ -176,6 +176,7 @@ static int dw_mci_exynos_runtime_resume(struct device *dev)

>  #ifdef CONFIG_PM_SLEEP

>  /**

>   * dw_mci_exynos_suspend_noirq - Exynos-specific suspend code

> + * @dev: Device to suspend (this device)

>   *

>   * This ensures that device will be in runtime active state in

>   * dw_mci_exynos_resume_noirq after calling pm_runtime_force_resume()

> @@ -188,6 +189,7 @@ static int dw_mci_exynos_suspend_noirq(struct device *dev)

>  

>  /**

>   * dw_mci_exynos_resume_noirq - Exynos-specific resume code

> + * @dev: Device to resume (this device)

>   *

>   * On exynos5420 there is a silicon errata that will sometimes leave the

>   * WAKEUP_INT bit in the CLKSEL register asserted.  This bit is 1 to indicate

>

Patch

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 5e3d95b636769..bd59186f59b39 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -176,6 +176,7 @@  static int dw_mci_exynos_runtime_resume(struct device *dev)
 #ifdef CONFIG_PM_SLEEP
 /**
  * dw_mci_exynos_suspend_noirq - Exynos-specific suspend code
+ * @dev: Device to suspend (this device)
  *
  * This ensures that device will be in runtime active state in
  * dw_mci_exynos_resume_noirq after calling pm_runtime_force_resume()
@@ -188,6 +189,7 @@  static int dw_mci_exynos_suspend_noirq(struct device *dev)
 
 /**
  * dw_mci_exynos_resume_noirq - Exynos-specific resume code
+ * @dev: Device to resume (this device)
  *
  * On exynos5420 there is a silicon errata that will sometimes leave the
  * WAKEUP_INT bit in the CLKSEL register asserted.  This bit is 1 to indicate