From patchwork Thu Jul 2 14:46:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 192260 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp1511022ilg; Thu, 2 Jul 2020 07:48:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUwyhVW0WjtXmYrH6/xoBX4Wi7hJvjzMnjmQ7SGfXDwiFwxdB/76k8FctqdtwBy2QiMYB/ X-Received: by 2002:a05:6402:1c11:: with SMTP id ck17mr33562749edb.38.1593701294898; Thu, 02 Jul 2020 07:48:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593701294; cv=none; d=google.com; s=arc-20160816; b=E5o/f09dNf+dVMCL71hdWBrmCbuOCRxDedDhY+wwoi1VBsrVVs6RcGxmEs/1UM4obU pDk/75/LTl5UtM06aN2G9wEs2LT2Bujf+SgatPvBbjZanBpzeFtrOc6rstRwrSlz/XaS jG+7/Cg0p6E5CaUbcHbrXEtP+85772DlcTjDOxxPjFZb/diplKJoLlWngw+eVkphO6HN FltE/kZxpC+J8VCJeaH+6/9xr/iLF/q2Na7nVqcIWGztAEDJr8Ufaik1J2zS7dTYtM2A 9G3iF5RwStwUEQYZM8mj/b8WTMKs+WxnAhuoglZ8D2dzOwFBOXnfGdv1u1P1ZzLNX+PD qZiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=28X3U4dJc3uramg6kDHLLVs+7HIKsy1aJX4qqakHpps=; b=OVYhVaCQGF2uCih7WrJWq6xpxKByeW79HAQUcZWfPnifJcFpe2yE3DwlWlYLZ2EmBS e8ERwNlINVCJWqY7AlRt95nj8VME91t+WaitCO5v5tnghXXlRTUoo4UqBLtSim6SjHb+ /6FGDvCH8Yu4TNKHeFD3eNaP+M6WoE8fgU3jdUqI+rzmbZ31SU9XgiFLiyra8ZxOSCUE sJyi208u9vyz0imXPjOcSp2Dzwq0e5wd/0gWyMw3PRLqJhuhksi7S5RmZtVxZy6AWxIz fdvQCWOY+08Oc2H0Az34w75MAJLhaKqqWf8pT/Dy1QE3ZJtx7wcu2k08N4iB+Aql4g4J UkMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DoVlnDUG; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si5880374eje.121.2020.07.02.07.48.14; Thu, 02 Jul 2020 07:48:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DoVlnDUG; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730046AbgGBOq7 (ORCPT + 5 others); Thu, 2 Jul 2020 10:46:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730038AbgGBOq6 (ORCPT ); Thu, 2 Jul 2020 10:46:58 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5178C08C5C1 for ; Thu, 2 Jul 2020 07:46:57 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l17so27119287wmj.0 for ; Thu, 02 Jul 2020 07:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=28X3U4dJc3uramg6kDHLLVs+7HIKsy1aJX4qqakHpps=; b=DoVlnDUG55Z4Fzv9+d1V8Ieq224Bfdh8KlYCNDYO1eP2cAbL9Nih/BvbtIkArPTCgY 9VJgpbG9xQ71lm4ghblIel7Ajs+qU1OqUnTyaCshoagZiUE2MzvozTLZotuvn5FmGeP+ YOdVX4MTT9x5O+qveBt4kpo/oJKwWt+EU5xKr0VvewkyHWF9badOtmf1EYeDEQ4jvDpf nXl4J32zR7BlkJVzhTaX8z1hR7v+7RgJuKlrcj9CO/hdrTRAw0GKFQCyJ0gIVKfjAL0A RI8wMjBewSNCZsWaWT3urJ4JA12qcvR3+GSQ+TyQyAid8K8Az19vtresRc7nwlXYT8ZC 1QKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=28X3U4dJc3uramg6kDHLLVs+7HIKsy1aJX4qqakHpps=; b=OKRpdwzJd5OuBi6vu0xZJF4nkGb2STDSbqp/TQDWjEUZ1d8Zs/b52Nh635NhtSDb9v YzFyA0FczIZftJI7Prpxp7nYe0QJgQbPwLu3+cnyYtkWXkGFF6XCiPzkMnIICS9Z/GI4 cglJc3T8MdfjXYNxh/EgscdFoh8IdNIHZnBFcUboYDxPHRbIYGo7uAzxQIBJTQBcAjSc e3ccvg6JKeU6fmjzGBCIprc+xQfOPS6vomtup4jrEvQrgsdSpDYczFjvfAqhVS65IMMp woRTwOv0A8616/OFDUyXHiK2nyRBrQiPCfdarE/OKIz474jE0C8j+3cDZyaczAjnUjYF gDhw== X-Gm-Message-State: AOAM530+5vYnxoAf2y/+guzfjFp/N6pIs9g09OvUayMGd6QTaTg+gn4/ sS6JXkkAzw7mZgKAQp9TylBvIA== X-Received: by 2002:a7b:c3d0:: with SMTP id t16mr34760561wmj.117.1593701216646; Thu, 02 Jul 2020 07:46:56 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:56 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Alan Stern , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Thibaut VARENE Subject: [PATCH 20/30] usb: host: ohci-at91: Demote kerneldoc headers down to basic comment blocks Date: Thu, 2 Jul 2020 15:46:15 +0100 Message-Id: <20200702144625.2533530-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Neither usb_hcd_at91_probe() nor usb_hcd_at91_remove()'s function headers reach the standards required of a kerneldoc entry. Only one attempt at describing an argument was made, as it is not correct (we're removing that too to save confusion). Fixes the following kernel build warning(s): drivers/usb/host/ohci-at91.c:166: warning: Function parameter or member 'driver' not described in 'usb_hcd_at91_probe' drivers/usb/host/ohci-at91.c:166: warning: Function parameter or member 'pdev' not described in 'usb_hcd_at91_probe' drivers/usb/host/ohci-at91.c:259: warning: Function parameter or member 'hcd' not described in 'usb_hcd_at91_remove' drivers/usb/host/ohci-at91.c:259: warning: Function parameter or member 'pdev' not described in 'usb_hcd_at91_remove' drivers/usb/host/ohci-at91.c:259: warning: Excess function parameter 'dev' description in 'usb_hcd_at91_remove' Cc: Alan Stern Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: Thibaut VARENE Signed-off-by: Lee Jones --- drivers/usb/host/ohci-at91.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index b635c6a1b1a91..0487a4b0501ec 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -153,7 +153,7 @@ static struct regmap *at91_dt_syscon_sfr(void) /* always called with process context; sleeping is OK */ -/** +/* * usb_hcd_at91_probe - initialize AT91-based HCDs * Context: !in_interrupt() * @@ -244,9 +244,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver, /* may be called with controller, bus, and devices active */ -/** +/* * usb_hcd_at91_remove - shutdown processing for AT91-based HCDs - * @dev: USB Host Controller being removed * Context: !in_interrupt() * * Reverses the effect of usb_hcd_at91_probe(), first invoking