[v4,3/3] ARM: bcm281xx: Device Tree bindings for GPIO driver

Message ID 1376938761-13657-4-git-send-email-markus.mayer@linaro.org
State New
Headers show

Commit Message

Markus Mayer Aug. 19, 2013, 6:59 p.m.
GPIO device tree bindings for the Broadcom bcm281xx family of chips

Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
---
 arch/arm/boot/dts/bcm11351.dtsi |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Tomasz Figa Aug. 19, 2013, 9:45 p.m. | #1
Hi Markus,

The patch looks good overall, just a little nitpick about the commit 
message.

On Monday 19 of August 2013 11:59:21 Markus Mayer wrote:
> GPIO device tree bindings for the Broadcom bcm281xx family of chips

Device tree bindings are sets of properties and subnodes defined for 
device nodes used to describe those devices. In other words, bindings are 
what you have described in numerous files 
Documentation/devicetree/bindings.

What this patch is adding is a device node for the GPIO controller of 
bcm11351.

Other than that:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz
Markus Mayer Aug. 19, 2013, 10:31 p.m. | #2
On 19 August 2013 14:45, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Markus,
>
> The patch looks good overall, just a little nitpick about the commit
> message.
>
> On Monday 19 of August 2013 11:59:21 Markus Mayer wrote:
>> GPIO device tree bindings for the Broadcom bcm281xx family of chips
>
> Device tree bindings are sets of properties and subnodes defined for
> device nodes used to describe those devices. In other words, bindings are
> what you have described in numerous files
> Documentation/devicetree/bindings.
>
> What this patch is adding is a device node for the GPIO controller of
> bcm11351.
>
> Other than that:
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Thanks. Does this look okay?

-----
ARM: bcm281xx: Add device node for the GPIO controller

Add the GPIO controller device node for the Broadcom bcm281xx family of
chips
-----

bcm11351 is one flavour of the bcm281xx family (long story why the
numbers look completely different), so I'd rather use that in the
description.

Regards,
-Markus
Linus Walleij Aug. 23, 2013, 5:38 p.m. | #3
On Mon, Aug 19, 2013 at 8:59 PM, Markus Mayer <markus.mayer@linaro.org> wrote:

> GPIO device tree bindings for the Broadcom bcm281xx family of chips
>
> Signed-off-by: Markus Mayer <markus.mayer@linaro.org>
> Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> ---
>  arch/arm/boot/dts/bcm11351.dtsi |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
> index c0cdf66..a3945e3 100644
> --- a/arch/arm/boot/dts/bcm11351.dtsi
> +++ b/arch/arm/boot/dts/bcm11351.dtsi
> @@ -63,6 +63,22 @@
>                 clock-frequency = <32768>;
>         };
>
> +       gpio: gpio@35003000 {
> +               compatible = "brcm,bcm11351-gpio", "brcm,kona-gpio";
> +               reg = <0x35003000 0x800>;
> +               interrupts =
> +                      <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH
> +                       GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH
> +                       GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH
> +                       GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH
> +                       GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH
> +                       GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
> +               #gpio-cells = <2>;
> +               #interrupt-cells = <2>;
> +               gpio-controller;
> +               interrupt-controller;
> +       };

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Patch

diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
index c0cdf66..a3945e3 100644
--- a/arch/arm/boot/dts/bcm11351.dtsi
+++ b/arch/arm/boot/dts/bcm11351.dtsi
@@ -63,6 +63,22 @@ 
 		clock-frequency = <32768>;
 	};
 
+	gpio: gpio@35003000 {
+		compatible = "brcm,bcm11351-gpio", "brcm,kona-gpio";
+		reg = <0x35003000 0x800>;
+		interrupts =
+		       <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH
+			GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH
+			GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH
+			GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH
+			GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH
+			GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>;
+		#gpio-cells = <2>;
+		#interrupt-cells = <2>;
+		gpio-controller;
+		interrupt-controller;
+	};
+
 	sdio0: sdio@0x3f180000 {
 		compatible = "bcm,kona-sdhci";
 		reg = <0x3f180000 0x10000>;