stdlib/Makefile: Link tst-tls-atexit without --as-needed.

Message ID mvm38q3jlfe.fsf@hawking.suse.de
State New
Headers show

Commit Message

Andreas Schwab Aug. 21, 2013, 12:08 p.m.
Will Newton <will.newton@linaro.org> writes:

> Is there a better way to fix it than the patch I proposed?

Please try this:



Andreas.

Comments

Will Newton Aug. 23, 2013, 12:17 p.m. | #1
On 21 August 2013 13:08, Andreas Schwab <schwab@suse.de> wrote:
> Will Newton <will.newton@linaro.org> writes:
>
>> Is there a better way to fix it than the patch I proposed?
>
> Please try this:
>
> diff --git a/stdlib/Makefile b/stdlib/Makefile
> index 17d80e0..b76c97a 100644
> --- a/stdlib/Makefile
> +++ b/stdlib/Makefile
> @@ -161,6 +161,6 @@ $(objpfx)tst-strtod6: $(link-libm)
>
>  tst-tls-atexit-lib.so-no-z-defs = yes
>
> -LDFLAGS-tst-tls-atexit = $(common-objpfx)nptl/libpthread.so \
> +$(objpfx)tst-tls-atexit: $(common-objpfx)nptl/libpthread.so \
>                          $(common-objpfx)dlfcn/libdl.so
>  $(objpfx)tst-tls-atexit.out: $(objpfx)tst-tls-atexit-lib.so

Yes, that seems to fix the problem too. Thanks!
Andreas Schwab Aug. 26, 2013, 8:23 a.m. | #2
Will Newton <will.newton@linaro.org> writes:

> On 21 August 2013 13:08, Andreas Schwab <schwab@suse.de> wrote:
>> Will Newton <will.newton@linaro.org> writes:
>>
>>> Is there a better way to fix it than the patch I proposed?
>>
>> Please try this:
>>
>> diff --git a/stdlib/Makefile b/stdlib/Makefile
>> index 17d80e0..b76c97a 100644
>> --- a/stdlib/Makefile
>> +++ b/stdlib/Makefile
>> @@ -161,6 +161,6 @@ $(objpfx)tst-strtod6: $(link-libm)
>>
>>  tst-tls-atexit-lib.so-no-z-defs = yes
>>
>> -LDFLAGS-tst-tls-atexit = $(common-objpfx)nptl/libpthread.so \
>> +$(objpfx)tst-tls-atexit: $(common-objpfx)nptl/libpthread.so \
>>                          $(common-objpfx)dlfcn/libdl.so
>>  $(objpfx)tst-tls-atexit.out: $(objpfx)tst-tls-atexit-lib.so
>
> Yes, that seems to fix the problem too. Thanks!

Thanks, installed.

Andreas.

Patch

diff --git a/stdlib/Makefile b/stdlib/Makefile
index 17d80e0..b76c97a 100644
--- a/stdlib/Makefile
+++ b/stdlib/Makefile
@@ -161,6 +161,6 @@  $(objpfx)tst-strtod6: $(link-libm)
 
 tst-tls-atexit-lib.so-no-z-defs = yes
 
-LDFLAGS-tst-tls-atexit = $(common-objpfx)nptl/libpthread.so \
+$(objpfx)tst-tls-atexit: $(common-objpfx)nptl/libpthread.so \
 			 $(common-objpfx)dlfcn/libdl.so
 $(objpfx)tst-tls-atexit.out: $(objpfx)tst-tls-atexit-lib.so