[06/18] ASoC: Intel: kbl_da7219_max98927: test return value on route add

Message ID 20200113210428.27457-7-pierre-louis.bossart@linux.intel.com
State Accepted
Commit 2b66c70fbe64c8fd47abd62e601f2405c7810f04
Headers show
Series
  • [01/18] ASoC: Intel: bxt_da7219_max98357a: rename shadowed variable
Related show

Commit Message

Pierre-Louis Bossart Jan. 13, 2020, 9:04 p.m.
Fix cppcheck warning:

[sound/soc/intel/boards/kbl_da7219_max98927.c:340] ->
[sound/soc/intel/boards/kbl_da7219_max98927.c:348]: (style) Variable
'ret' is reassigned a value before the old one has been used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/kbl_da7219_max98927.c | 3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/sound/soc/intel/boards/kbl_da7219_max98927.c b/sound/soc/intel/boards/kbl_da7219_max98927.c
index 34e734adac19..e8b2ec60fb03 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98927.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98927.c
@@ -341,6 +341,9 @@  static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
 			kabylake_ssp1_map,
 			ARRAY_SIZE(kabylake_ssp1_map));
 
+	if (ret)
+		return ret;
+
 	/*
 	 * Headset buttons map to the google Reference headset.
 	 * These can be configured by userspace.