[-next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error

Message ID ce0d7561-ff93-d267-b57a-6505014c728c@infradead.org
State New
Headers show
Series
  • [-next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
Related show

Commit Message

Randy Dunlap June 29, 2020, 4:43 p.m.
From: Randy Dunlap <rdunlap@infradead.org>

Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
by adding a stub for of_get_next_parent().

../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
---
 include/linux/of.h |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring July 10, 2020, 3:28 p.m. | #1
On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>

> From: Randy Dunlap <rdunlap@infradead.org>

>

> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled

> by adding a stub for of_get_next_parent().

>

> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]

> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]

>


Fixes tag?

> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> Cc: Rob Herring <robh+dt@kernel.org>

> Cc: Frank Rowand <frowand.list@gmail.com>

> Cc: devicetree@vger.kernel.org

> Cc: Andy Gross <agross@kernel.org>

> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> Cc: linux-arm-msm@vger.kernel.org

> ---

>  include/linux/of.h |    5 +++++

>  1 file changed, 5 insertions(+)


I'm assuming this will be applied to the tree that introduced the problem.

Acked-by: Rob Herring <robh@kernel.org>
Randy Dunlap July 10, 2020, 11:40 p.m. | #2
On 7/10/20 8:28 AM, Rob Herring wrote:
> On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:

>>

>> From: Randy Dunlap <rdunlap@infradead.org>

>>

>> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled

>> by adding a stub for of_get_next_parent().

>>

>> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]

>> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]

>>

> 

> Fixes tag?


Are linux-next hashes/tags stable?

Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")

>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

>> Cc: Rob Herring <robh+dt@kernel.org>

>> Cc: Frank Rowand <frowand.list@gmail.com>

>> Cc: devicetree@vger.kernel.org

>> Cc: Andy Gross <agross@kernel.org>

>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

>> Cc: linux-arm-msm@vger.kernel.org

>> ---

>>  include/linux/of.h |    5 +++++

>>  1 file changed, 5 insertions(+)

> 

> I'm assuming this will be applied to the tree that introduced the problem.

> 

> Acked-by: Rob Herring <robh@kernel.org>

> 


Hi Akash,
Can you add this patch to your tree, as Rob indicated above?

thanks.
-- 
~Randy
Bjorn Andersson July 11, 2020, 7:41 p.m. | #3
On Fri 10 Jul 16:40 PDT 2020, Randy Dunlap wrote:

> On 7/10/20 8:28 AM, Rob Herring wrote:

> > On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:

> >>

> >> From: Randy Dunlap <rdunlap@infradead.org>

> >>

> >> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled

> >> by adding a stub for of_get_next_parent().

> >>

> >> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]

> >> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]

> >>

> > 

> > Fixes tag?

> 

> Are linux-next hashes/tags stable?

> 


Yes, the hashes of the Qualcomm tree are stable.

> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")

> 


Thank you, added this to the commit and...

> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

> >> Cc: Rob Herring <robh+dt@kernel.org>

> >> Cc: Frank Rowand <frowand.list@gmail.com>

> >> Cc: devicetree@vger.kernel.org

> >> Cc: Andy Gross <agross@kernel.org>

> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>

> >> Cc: linux-arm-msm@vger.kernel.org

> >> ---

> >>  include/linux/of.h |    5 +++++

> >>  1 file changed, 5 insertions(+)

> > 

> > I'm assuming this will be applied to the tree that introduced the problem.

> > 

> > Acked-by: Rob Herring <robh@kernel.org>

> > 

> 

> Hi Akash,

> Can you add this patch to your tree, as Rob indicated above?

> 


...applied it to the Qualcomm "drivers" tree for 5.9.

Thanks for the patch Randy and thanks for the Ack, Rob.

Regards,
Bjorn

> thanks.

> -- 

> ~Randy

>

Patch

--- linux-next-20200629.orig/include/linux/of.h
+++ linux-next-20200629/include/linux/of.h
@@ -630,6 +630,11 @@  static inline struct device_node *of_get
 	return NULL;
 }
 
+static inline struct device_node *of_get_next_parent(struct device_node *node)
+{
+	return NULL;
+}
+
 static inline struct device_node *of_get_next_child(
 	const struct device_node *node, struct device_node *prev)
 {