benchtests/Makefile: Use LDLIBS instead of LDFLAGS.

Message ID 52249EAA.80209@linaro.org
State Accepted
Headers show

Commit Message

Will Newton Sept. 2, 2013, 2:20 p.m.
LDFLAGS puts the library too early in the command line if --as-needed
is being used. Use LDLIBS instead.

ChangeLog:

2013-09-02  Will Newton  <will.newton@linaro.org>

	* benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
---
 benchtests/Makefile | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

Comments

Siddhesh Poyarekar Sept. 2, 2013, 2:37 p.m. | #1
On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
> 
> LDFLAGS puts the library too early in the command line if --as-needed
> is being used. Use LDLIBS instead.
> 
> ChangeLog:
> 
> 2013-09-02  Will Newton  <will.newton@linaro.org>
> 
> 	* benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
> ---
>  benchtests/Makefile | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)

Looks good to me.

Thanks,
Siddhesh

> diff --git a/benchtests/Makefile b/benchtests/Makefile
> index ba313d2..4d4b909 100644
> --- a/benchtests/Makefile
> +++ b/benchtests/Makefile
> @@ -36,67 +36,67 @@ benchset := $(string-bench-all)
> 
>  acos-ARGLIST = double
>  acos-RET = double
> -LDFLAGS-bench-acos = -lm
> +LDLIBS-bench-acos = -lm
> 
>  acosh-ARGLIST = double
>  acosh-RET = double
> -LDFLAGS-bench-acosh = -lm
> +LDLIBS-bench-acosh = -lm
> 
>  asin-ARGLIST = double
>  asin-RET = double
> -LDFLAGS-bench-asin = -lm
> +LDLIBS-bench-asin = -lm
> 
>  asinh-ARGLIST = double
>  asinh-RET = double
> -LDFLAGS-bench-asinh = -lm
> +LDLIBS-bench-asinh = -lm
> 
>  atan-ARGLIST = double
>  atan-RET = double
> -LDFLAGS-bench-atan = -lm
> +LDLIBS-bench-atan = -lm
> 
>  atanh-ARGLIST = double
>  atanh-RET = double
> -LDFLAGS-bench-atanh = -lm
> +LDLIBS-bench-atanh = -lm
> 
>  cos-ARGLIST = double
>  cos-RET = double
> -LDFLAGS-bench-cos = -lm
> +LDLIBS-bench-cos = -lm
> 
>  cosh-ARGLIST = double
>  cosh-RET = double
> -LDFLAGS-bench-cosh = -lm
> +LDLIBS-bench-cosh = -lm
> 
>  exp-ARGLIST = double
>  exp-RET = double
> -LDFLAGS-bench-exp = -lm
> +LDLIBS-bench-exp = -lm
> 
>  log-ARGLIST = double
>  log-RET = double
> -LDFLAGS-bench-log = -lm
> +LDLIBS-bench-log = -lm
> 
>  pow-ARGLIST = double:double
>  pow-RET = double
> -LDFLAGS-bench-pow = -lm
> +LDLIBS-bench-pow = -lm
> 
>  rint-ARGLIST = double
>  rint-RET = double
> -LDFLAGS-bench-rint = -lm
> +LDLIBS-bench-rint = -lm
> 
>  sin-ARGLIST = double
>  sin-RET = double
> -LDFLAGS-bench-sin = -lm
> +LDLIBS-bench-sin = -lm
> 
>  sinh-ARGLIST = double
>  sinh-RET = double
> -LDFLAGS-bench-sinh = -lm
> +LDLIBS-bench-sinh = -lm
> 
>  tan-ARGLIST = double
>  tan-RET = double
> -LDFLAGS-bench-tan = -lm
> +LDLIBS-bench-tan = -lm
> 
>  tanh-ARGLIST = double
>  tanh-RET = double
> -LDFLAGS-bench-tanh = -lm
> +LDLIBS-bench-tanh = -lm
> 
>  
> 
> -- 
> 1.8.1.4
>
Will Newton Sept. 3, 2013, 4:43 p.m. | #2
On 2 September 2013 15:37, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
>>
>> LDFLAGS puts the library too early in the command line if --as-needed
>> is being used. Use LDLIBS instead.
>>
>> ChangeLog:
>>
>> 2013-09-02  Will Newton  <will.newton@linaro.org>
>>
>>       * benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
>> ---
>>  benchtests/Makefile | 32 ++++++++++++++++----------------
>>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> Looks good to me.

Is it ok to go ahead and commit?

Thanks,
Siddhesh Poyarekar Sept. 3, 2013, 4:47 p.m. | #3
On Tue, Sep 03, 2013 at 05:43:06PM +0100, Will Newton wrote:
> On 2 September 2013 15:37, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> > On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
> >>
> >> LDFLAGS puts the library too early in the command line if --as-needed
> >> is being used. Use LDLIBS instead.
> >>
> >> ChangeLog:
> >>
> >> 2013-09-02  Will Newton  <will.newton@linaro.org>
> >>
> >>       * benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
> >> ---
> >>  benchtests/Makefile | 32 ++++++++++++++++----------------
> >>  1 file changed, 16 insertions(+), 16 deletions(-)
> >
> > Looks good to me.
> 
> Is it ok to go ahead and commit?

Yes, unless you would like additional review.

Siddhesh
Will Newton Sept. 4, 2013, 2:44 p.m. | #4
On 3 September 2013 17:47, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Tue, Sep 03, 2013 at 05:43:06PM +0100, Will Newton wrote:
>> On 2 September 2013 15:37, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> > On Mon, Sep 02, 2013 at 03:20:26PM +0100, Will Newton wrote:
>> >>
>> >> LDFLAGS puts the library too early in the command line if --as-needed
>> >> is being used. Use LDLIBS instead.
>> >>
>> >> ChangeLog:
>> >>
>> >> 2013-09-02  Will Newton  <will.newton@linaro.org>
>> >>
>> >>       * benchtests/Makefile: Use LDLIBS instead of LDFLAGS.
>> >> ---
>> >>  benchtests/Makefile | 32 ++++++++++++++++----------------
>> >>  1 file changed, 16 insertions(+), 16 deletions(-)
>> >
>> > Looks good to me.
>>
>> Is it ok to go ahead and commit?
>
> Yes, unless you would like additional review.

Thanks, applied.

Patch

diff --git a/benchtests/Makefile b/benchtests/Makefile
index ba313d2..4d4b909 100644
--- a/benchtests/Makefile
+++ b/benchtests/Makefile
@@ -36,67 +36,67 @@  benchset := $(string-bench-all)

 acos-ARGLIST = double
 acos-RET = double
-LDFLAGS-bench-acos = -lm
+LDLIBS-bench-acos = -lm

 acosh-ARGLIST = double
 acosh-RET = double
-LDFLAGS-bench-acosh = -lm
+LDLIBS-bench-acosh = -lm

 asin-ARGLIST = double
 asin-RET = double
-LDFLAGS-bench-asin = -lm
+LDLIBS-bench-asin = -lm

 asinh-ARGLIST = double
 asinh-RET = double
-LDFLAGS-bench-asinh = -lm
+LDLIBS-bench-asinh = -lm

 atan-ARGLIST = double
 atan-RET = double
-LDFLAGS-bench-atan = -lm
+LDLIBS-bench-atan = -lm

 atanh-ARGLIST = double
 atanh-RET = double
-LDFLAGS-bench-atanh = -lm
+LDLIBS-bench-atanh = -lm

 cos-ARGLIST = double
 cos-RET = double
-LDFLAGS-bench-cos = -lm
+LDLIBS-bench-cos = -lm

 cosh-ARGLIST = double
 cosh-RET = double
-LDFLAGS-bench-cosh = -lm
+LDLIBS-bench-cosh = -lm

 exp-ARGLIST = double
 exp-RET = double
-LDFLAGS-bench-exp = -lm
+LDLIBS-bench-exp = -lm

 log-ARGLIST = double
 log-RET = double
-LDFLAGS-bench-log = -lm
+LDLIBS-bench-log = -lm

 pow-ARGLIST = double:double
 pow-RET = double
-LDFLAGS-bench-pow = -lm
+LDLIBS-bench-pow = -lm

 rint-ARGLIST = double
 rint-RET = double
-LDFLAGS-bench-rint = -lm
+LDLIBS-bench-rint = -lm

 sin-ARGLIST = double
 sin-RET = double
-LDFLAGS-bench-sin = -lm
+LDLIBS-bench-sin = -lm

 sinh-ARGLIST = double
 sinh-RET = double
-LDFLAGS-bench-sinh = -lm
+LDLIBS-bench-sinh = -lm

 tan-ARGLIST = double
 tan-RET = double
-LDFLAGS-bench-tan = -lm
+LDLIBS-bench-tan = -lm

 tanh-ARGLIST = double
 tanh-RET = double
-LDFLAGS-bench-tanh = -lm
+LDLIBS-bench-tanh = -lm