[v3,01/13] crypto: amlogic-gxl - default to build as module

Message ID 20200630121907.24274-2-ardb@kernel.org
State Superseded
Headers show
Series
  • [v3,01/13] crypto: amlogic-gxl - default to build as module
Related show

Commit Message

Ard Biesheuvel June 30, 2020, 12:18 p.m.
The AmLogic GXL crypto accelerator driver is built into the kernel if
ARCH_MESON is set. However, given the single image policy of arm64, its
defconfig enables all platforms by default, and so ARCH_MESON is usually
enabled.

This means that the AmLogic driver causes the arm64 defconfig build to
pull in a huge chunk of the crypto stack as a builtin as well, which is
undesirable, so let's make the amlogic GXL driver default to 'm' instead.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 drivers/crypto/amlogic/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Corentin Labbe July 6, 2020, 5:41 p.m. | #1
On Tue, Jun 30, 2020 at 02:18:55PM +0200, Ard Biesheuvel wrote:
> The AmLogic GXL crypto accelerator driver is built into the kernel if

> ARCH_MESON is set. However, given the single image policy of arm64, its

> defconfig enables all platforms by default, and so ARCH_MESON is usually

> enabled.

> 

> This means that the AmLogic driver causes the arm64 defconfig build to

> pull in a huge chunk of the crypto stack as a builtin as well, which is

> undesirable, so let's make the amlogic GXL driver default to 'm' instead.

> 

> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

> ---

>  drivers/crypto/amlogic/Kconfig | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 


Tested-by: Corentin Labbe <clabbe@baylibre.com>


Note: you didnt CC my work address, so I answer with my personnal one.
I fear to fake some message-id.

Patch

diff --git a/drivers/crypto/amlogic/Kconfig b/drivers/crypto/amlogic/Kconfig
index cf9547602670..cf2c676a7093 100644
--- a/drivers/crypto/amlogic/Kconfig
+++ b/drivers/crypto/amlogic/Kconfig
@@ -1,7 +1,7 @@ 
 config CRYPTO_DEV_AMLOGIC_GXL
 	tristate "Support for amlogic cryptographic offloader"
 	depends on HAS_IOMEM
-	default y if ARCH_MESON
+	default m if ARCH_MESON
 	select CRYPTO_SKCIPHER
 	select CRYPTO_ENGINE
 	select CRYPTO_ECB