crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init

Message ID 20200622024014.11347-1-dinghao.liu@zju.edu.cn
State Accepted
Commit 5c3a8a661e1bd9d7063485ac2d2ccb512c447129
Headers show
Series
  • crypto: sun8i-ce - Fix runtime PM imbalance in sun8i_ce_cipher_init
Related show

Commit Message

Dinghao Liu June 22, 2020, 2:40 a.m.
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a corresponding decrement is
needed on the error handling path to keep the counter balanced.

Fix this by adding the missed function call.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Herbert Xu July 3, 2020, 4:47 a.m. | #1
On Mon, Jun 22, 2020 at 10:40:08AM +0800, Dinghao Liu wrote:
> pm_runtime_get_sync() increments the runtime PM usage counter even

> the call returns an error code. Thus a corresponding decrement is

> needed on the error handling path to keep the counter balanced.

> 

> Fix this by adding the missed function call.

> 

> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

> ---

>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 1 +

>  1 file changed, 1 insertion(+)


Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Patch

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index a6abb701bfc6..3665a0a2038f 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -358,6 +358,7 @@  int sun8i_ce_cipher_init(struct crypto_tfm *tfm)
 
 	return 0;
 error_pm:
+	pm_runtime_put_noidle(op->ce->dev);
 	crypto_free_sync_skcipher(op->fallback_tfm);
 	return err;
 }