[v4,3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()

Message ID 20200616015718.7812-4-longman@redhat.com
State Superseded
Headers show
  • [v4,1/3] mm/slab: Use memzero_explicit() in kzfree()
Related show

Commit Message

Waiman Long June 16, 2020, 1:57 a.m.
In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
was incorrectly paired with kzfree(). According to David Sterba, there
isn't any sensitive information in the subvol_info that needs to be
cleared before freeing. So kfree_sensitive() isn't really needed,
use kfree() instead.

Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Waiman Long <longman@redhat.com>
 fs/btrfs/ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index f1dd9e4271e9..e8f7c5f00894 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2692,7 +2692,7 @@  static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
-	kfree_sensitive(subvol_info);
+	kfree(subvol_info);
 	return ret;