| Message ID | 20200619125801.9530-8-faiz_abbas@ti.com |
|---|---|
| State | Accepted |
| Commit | 3506ddd676a3c617d4679382dc9cdbb30d4c69a7 |
| Headers | show |
| Series | Add support for SD card in AM654x-evm | expand |
Hi, On 16/07/20 11:58 pm, Arnd Bergmann wrote: > On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori <nsekhar@ti.com> wrote: >> >> On 7/16/20 5:49 PM, Faiz Abbas wrote: >>> Hi, >>> >>> On 19/06/20 6:28 pm, Faiz Abbas wrote: >>>> Enable CONFIG_SDHCI_AM654 to Support AM65x sdhci controller. >>>> >>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>> --- >>>> arch/arm64/configs/defconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>> index 883e8bace3ed..40dd13e0adc5 100644 >>>> --- a/arch/arm64/configs/defconfig >>>> +++ b/arch/arm64/configs/defconfig >>>> @@ -731,6 +731,7 @@ CONFIG_MMC_DW_ROCKCHIP=y >>>> CONFIG_MMC_SUNXI=y >>>> CONFIG_MMC_BCM2835=y >>>> CONFIG_MMC_SDHCI_XENON=y >>>> +CONFIG_MMC_SDHCI_AM654=y >>>> CONFIG_MMC_OWL=y >>>> CONFIG_NEW_LEDS=y >>>> CONFIG_LEDS_CLASS=y >>>> >>> >>> Gentle ping. Will, Catalin, can this patch be picked up? >> >> From logs, Arnd has been picking up patches for this file. Looping in >> Arnd and ARM-SoC team. > > I tend to ignore individual patches to the defconfig file unless > they are sent to:soc@kernel.org. The best way to get them > included is to have the platform maintainers pick up the > changes and send them that way as a separate pull request > at the same time as sending any DT updates. > > The MAINTAINERS file lists Tero and Nishanth as maintainers > for the platform. If they want, I can apply this one directly, but in > the future, send it to them. > Thanks for clarifying Arnd. Tero, can you pick this up? Thanks, Faiz
On 17/07/2020 11:38, Faiz Abbas wrote: > Hi, > > On 16/07/20 11:58 pm, Arnd Bergmann wrote: >> On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori <nsekhar@ti.com> wrote: >>> >>> On 7/16/20 5:49 PM, Faiz Abbas wrote: >>>> Hi, >>>> >>>> On 19/06/20 6:28 pm, Faiz Abbas wrote: >>>>> Enable CONFIG_SDHCI_AM654 to Support AM65x sdhci controller. >>>>> >>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>> --- >>>>> arch/arm64/configs/defconfig | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>>> index 883e8bace3ed..40dd13e0adc5 100644 >>>>> --- a/arch/arm64/configs/defconfig >>>>> +++ b/arch/arm64/configs/defconfig >>>>> @@ -731,6 +731,7 @@ CONFIG_MMC_DW_ROCKCHIP=y >>>>> CONFIG_MMC_SUNXI=y >>>>> CONFIG_MMC_BCM2835=y >>>>> CONFIG_MMC_SDHCI_XENON=y >>>>> +CONFIG_MMC_SDHCI_AM654=y >>>>> CONFIG_MMC_OWL=y >>>>> CONFIG_NEW_LEDS=y >>>>> CONFIG_LEDS_CLASS=y >>>>> >>>> >>>> Gentle ping. Will, Catalin, can this patch be picked up? >>> >>> From logs, Arnd has been picking up patches for this file. Looping in >>> Arnd and ARM-SoC team. >> >> I tend to ignore individual patches to the defconfig file unless >> they are sent to:soc@kernel.org. The best way to get them >> included is to have the platform maintainers pick up the >> changes and send them that way as a separate pull request >> at the same time as sending any DT updates. >> >> The MAINTAINERS file lists Tero and Nishanth as maintainers >> for the platform. If they want, I can apply this one directly, but in >> the future, send it to them. >> > > Thanks for clarifying Arnd. Tero, can you pick this up? Ok, this topic has been bit unclear for me also, but if you say I can pick the patches myself and send a pull request out, I can do that. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On Fri, Jul 17, 2020 at 1:20 PM Tero Kristo <t-kristo@ti.com> wrote: > On 17/07/2020 11:38, Faiz Abbas wrote: > > On 16/07/20 11:58 pm, Arnd Bergmann wrote: > >> On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori <nsekhar@ti.com> wrote: > >> I tend to ignore individual patches to the defconfig file unless > >> they are sent to:soc@kernel.org. The best way to get them > >> included is to have the platform maintainers pick up the > >> changes and send them that way as a separate pull request > >> at the same time as sending any DT updates. > >> > >> The MAINTAINERS file lists Tero and Nishanth as maintainers > >> for the platform. If they want, I can apply this one directly, but in > >> the future, send it to them. > >> > > > > Thanks for clarifying Arnd. Tero, can you pick this up? > > Ok, this topic has been bit unclear for me also, but if you say I can > pick the patches myself and send a pull request out, I can do that. Right. To clarify, the soc tree usually has separate branches for dts files, soc specific drivers, defconfig files and 32-bit platform code. When you pick up patches into your tree, please put them into branches that fit into those categories. You can group the patches into branches with more fine-grained categories if it makes sense (e.g. adding a particularly large driver, adding a new dts files for a new soc, or cosmetic cleanups across dts files). If any of the categories only have a couple of patches in them, you can decide to forward those as patches to soc@kernel.org, but a pull request is always ok as well, even for a one-line patch. Arnd Arnd
Tero, On 17/07/20 6:39 pm, Arnd Bergmann wrote: > On Fri, Jul 17, 2020 at 1:20 PM Tero Kristo <t-kristo@ti.com> wrote: >> On 17/07/2020 11:38, Faiz Abbas wrote: >>> On 16/07/20 11:58 pm, Arnd Bergmann wrote: >>>> On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori <nsekhar@ti.com> wrote: >>>> I tend to ignore individual patches to the defconfig file unless >>>> they are sent to:soc@kernel.org. The best way to get them >>>> included is to have the platform maintainers pick up the >>>> changes and send them that way as a separate pull request >>>> at the same time as sending any DT updates. >>>> >>>> The MAINTAINERS file lists Tero and Nishanth as maintainers >>>> for the platform. If they want, I can apply this one directly, but in >>>> the future, send it to them. >>>> >>> >>> Thanks for clarifying Arnd. Tero, can you pick this up? >> >> Ok, this topic has been bit unclear for me also, but if you say I can >> pick the patches myself and send a pull request out, I can do that. > Patches 1-6 are being merged from mmc tree. You only need to pick up this patch. Thanks, Faiz
On 17/07/2020 16:09, Arnd Bergmann wrote: > On Fri, Jul 17, 2020 at 1:20 PM Tero Kristo <t-kristo@ti.com> wrote: >> On 17/07/2020 11:38, Faiz Abbas wrote: >>> On 16/07/20 11:58 pm, Arnd Bergmann wrote: >>>> On Thu, Jul 16, 2020 at 3:25 PM Sekhar Nori <nsekhar@ti.com> wrote: >>>> I tend to ignore individual patches to the defconfig file unless >>>> they are sent to:soc@kernel.org. The best way to get them >>>> included is to have the platform maintainers pick up the >>>> changes and send them that way as a separate pull request >>>> at the same time as sending any DT updates. >>>> >>>> The MAINTAINERS file lists Tero and Nishanth as maintainers >>>> for the platform. If they want, I can apply this one directly, but in >>>> the future, send it to them. >>>> >>> >>> Thanks for clarifying Arnd. Tero, can you pick this up? >> >> Ok, this topic has been bit unclear for me also, but if you say I can >> pick the patches myself and send a pull request out, I can do that. > > Right. To clarify, the soc tree usually has separate branches for dts > files, soc specific drivers, defconfig files and 32-bit platform code. > > When you pick up patches into your tree, please put them into > branches that fit into those categories. You can group the patches > into branches with more fine-grained categories if it makes sense > (e.g. adding a particularly large driver, adding a new dts files for a > new soc, or cosmetic cleanups across dts files). > > If any of the categories only have a couple of patches in them, you > can decide to forward those as patches to soc@kernel.org, but a > pull request is always ok as well, even for a one-line patch. Ok thanks for clarification, Arnd. Based on that, queuing this up for 5.9 myself, thanks. Will post pull-request next week for it, there appears to be another K3 SoC related config change pending which I'll pick up also. Just want to capture -next results for these to see how well they integrate. -Tero -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 883e8bace3ed..40dd13e0adc5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -731,6 +731,7 @@ CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SUNXI=y CONFIG_MMC_BCM2835=y CONFIG_MMC_SDHCI_XENON=y +CONFIG_MMC_SDHCI_AM654=y CONFIG_MMC_OWL=y CONFIG_NEW_LEDS=y CONFIG_LEDS_CLASS=y
Enable CONFIG_SDHCI_AM654 to Support AM65x sdhci controller. Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)