gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs.

Message ID 5231DFF8.3030203@linaro.org
State Accepted
Headers show

Commit Message

Will Newton Sept. 12, 2013, 3:38 p.m.
Apply the same fix that was applied to aarch64-linux-nat.c.

2013-09-12  Will Newton  <will.newton@linaro.org>

	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
	out regs.
---
 gdb/gdbserver/linux-aarch64-low.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pedro Alves Sept. 16, 2013, 1:26 p.m. | #1
On 09/12/2013 04:38 PM, Will Newton wrote:
> 2013-09-12  Will Newton  <will.newton@linaro.org>
> 
> 	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
> 	out regs.

OK.
Will Newton Sept. 16, 2013, 2:23 p.m. | #2
On 16 September 2013 14:26, Pedro Alves <palves@redhat.com> wrote:
> On 09/12/2013 04:38 PM, Will Newton wrote:
>> 2013-09-12  Will Newton  <will.newton@linaro.org>
>>
>>       * linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
>>       out regs.
>
> OK.

Thanks, applied. OK for the 7.6 branch?
Pedro Alves Sept. 16, 2013, 2:27 p.m. | #3
On 09/16/2013 03:23 PM, Will Newton wrote:
> On 16 September 2013 14:26, Pedro Alves <palves@redhat.com> wrote:
>> On 09/12/2013 04:38 PM, Will Newton wrote:
>>> 2013-09-12  Will Newton  <will.newton@linaro.org>
>>>
>>>       * linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
>>>       out regs.
>>
>> OK.
> 
> Thanks, applied. OK for the 7.6 branch?

Sure.
Joel Brobecker Sept. 16, 2013, 3:33 p.m. | #4
> > Thanks, applied. OK for the 7.6 branch?
> 
> Sure.

All good from my end, but JIC I do not think we will be producing
another release off that branch...

Patch

diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
index e37f602..93246b3 100644
--- a/gdb/gdbserver/linux-aarch64-low.c
+++ b/gdb/gdbserver/linux-aarch64-low.c
@@ -600,6 +600,7 @@  aarch64_linux_set_debug_regs (const struct aarch64_debug_reg_state *state,
   const CORE_ADDR *addr;
   const unsigned int *ctrl;

+  memset (&regs, 0, sizeof (regs));
   iov.iov_base = &regs;
   iov.iov_len = sizeof (regs);
   count = watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs;