sysdeps/mach/hurd/i386/tls.h: Remove TLS_INIT_TP_EXPENSIVE.

Message ID 52409BA9.2030509@linaro.org
State Accepted
Headers show

Commit Message

Will Newton Sept. 23, 2013, 7:51 p.m.
This define was removed from the rest of the tree eight years ago.

ChangeLog:

2013-09-23  Will Newton  <will.newton@linaro.org>

	* sysdeps/mach/hurd/i386/tls.h (TLS_INIT_TP_EXPENSIVE): Remove
	macro.
---
 sysdeps/mach/hurd/i386/tls.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Schwinge Sept. 24, 2013, 8:17 a.m. | #1
Hi!

On Mon, 23 Sep 2013 20:51:05 +0100, Will Newton <will.newton@linaro.org> wrote:
> This define was removed from the rest of the tree eight years ago.

> 	* sysdeps/mach/hurd/i386/tls.h (TLS_INIT_TP_EXPENSIVE): Remove
> 	macro.

The same macro definition also exists in ports/sysdeps/arm/nptl/tls.h,
which I suggest you remove at the same time.  With that added, please
push.  This had been filed on
<http://www.gnu.org/software/hurd/open_issues/glibc/t/tls.html>, which
I'll update later.


Grüße,
 Thomas
Will Newton Sept. 24, 2013, 8:31 a.m. | #2
On 24 September 2013 09:17, Thomas Schwinge <thomas@codesourcery.com> wrote:
> Hi!
>
> On Mon, 23 Sep 2013 20:51:05 +0100, Will Newton <will.newton@linaro.org> wrote:
>> This define was removed from the rest of the tree eight years ago.
>
>>       * sysdeps/mach/hurd/i386/tls.h (TLS_INIT_TP_EXPENSIVE): Remove
>>       macro.
>
> The same macro definition also exists in ports/sysdeps/arm/nptl/tls.h,
> which I suggest you remove at the same time.  With that added, please
> push.  This had been filed on
> <http://www.gnu.org/software/hurd/open_issues/glibc/t/tls.html>, which
> I'll update later.

Thanks, I've already submitted a patch for that to libc-ports. I guess
it's another case where sending all the patches to one list would make
more sense. The patches are both applied now.
Roland McGrath Sept. 24, 2013, 6:10 p.m. | #3
OK

Patch

diff --git a/sysdeps/mach/hurd/i386/tls.h b/sysdeps/mach/hurd/i386/tls.h
index 4f4c7c5..da8c16a 100644
--- a/sysdeps/mach/hurd/i386/tls.h
+++ b/sysdeps/mach/hurd/i386/tls.h
@@ -118,7 +118,6 @@  _hurd_tls_init (tcbhead_t *tcb, int secondcall)
    operation can cause a failure 'errno' must not be touched.  */
 # define TLS_INIT_TP(descr, secondcall) \
     _hurd_tls_init ((tcbhead_t *) (descr), (secondcall))
-# define TLS_INIT_TP_EXPENSIVE 1

 /* Return the TCB address of the current thread.  */
 # define THREAD_SELF							      \