[v3,2/2] dt-bindings: gpio: Add bindings for NXP PCA9570

Message ID 20200630160934.1197066-1-mans0n@gorani.run
State New
Headers show
Series
  • Untitled series #35809
Related show

Commit Message

Sungbo Eo June 30, 2020, 4:09 p.m.
This patch adds device tree bindings for the NXP PCA9570,
a 4-bit I2C GPO expander.

Signed-off-by: Sungbo Eo <mans0n@gorani.run>
---
v3:
* fixed dt_binding_check error

v2:
I don't feel I can really maintain this driver, but it seems all yaml docs
have a maintainers field so I just added it...
---
 .../bindings/gpio/gpio-pca9570.yaml           | 47 +++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml

Comments

Rob Herring July 13, 2020, 7:07 p.m. | #1
On Wed, 01 Jul 2020 01:09:34 +0900, Sungbo Eo wrote:
> This patch adds device tree bindings for the NXP PCA9570,

> a 4-bit I2C GPO expander.

> 

> Signed-off-by: Sungbo Eo <mans0n@gorani.run>

> ---

> v3:

> * fixed dt_binding_check error

> 

> v2:

> I don't feel I can really maintain this driver, but it seems all yaml docs

> have a maintainers field so I just added it...

> ---

>  .../bindings/gpio/gpio-pca9570.yaml           | 47 +++++++++++++++++++

>  1 file changed, 47 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Linus Walleij July 16, 2020, 12:37 p.m. | #2
On Tue, Jun 30, 2020 at 6:10 PM Sungbo Eo <mans0n@gorani.run> wrote:

> This patch adds device tree bindings for the NXP PCA9570,

> a 4-bit I2C GPO expander.

>

> Signed-off-by: Sungbo Eo <mans0n@gorani.run>

> ---

> v3:


This v3 patch applied, thanks!

Yours,
Linus Walleij

Patch

diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
new file mode 100644
index 000000000000..338c5312a106
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/gpio-pca9570.yaml
@@ -0,0 +1,47 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/gpio-pca9570.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PCA9570 I2C GPO expander
+
+maintainers:
+  - Sungbo Eo <mans0n@gorani.run>
+
+properties:
+  compatible:
+    enum:
+      - nxp,pca9570
+
+  reg:
+    maxItems: 1
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    const: 2
+
+required:
+  - compatible
+  - reg
+  - gpio-controller
+  - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        gpio@24 {
+            compatible = "nxp,pca9570";
+            reg = <0x24>;
+            gpio-controller;
+            #gpio-cells = <2>;
+        };
+    };
+
+...