| Message ID | 20200521102205.16604-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Accepted |
| Commit | e40a8770fd147e7c0d5bd8c327d88090480242f2 |
| Headers | show |
| Series | media: fimc-capture: Fix runtime PM imbalance on error | expand |
diff --git a/drivers/media/platform/exynos4-is/fimc-capture.c b/drivers/media/platform/exynos4-is/fimc-capture.c index 705f182330ca..dd33b888971f 100644 --- a/drivers/media/platform/exynos4-is/fimc-capture.c +++ b/drivers/media/platform/exynos4-is/fimc-capture.c @@ -478,8 +478,10 @@ static int fimc_capture_open(struct file *file) set_bit(ST_CAPT_BUSY, &fimc->state); ret = pm_runtime_get_sync(&fimc->pdev->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_sync(&fimc->pdev->dev); goto unlock; + } ret = v4l2_fh_open(file); if (ret) {
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/media/platform/exynos4-is/fimc-capture.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)