diff mbox series

[v5,3/5] media: i2c: ov5645: Turn probe error into warning for xvclk frequency mismatch

Message ID 1586191361-16598-4-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com
State New
Headers show
Series [v5,1/5] media: dt-bindings: media: i2c: Deprecate usage of the clock-frequency property | expand

Commit Message

Prabhakar Mahadev Lad April 6, 2020, 4:42 p.m. UTC 
PLL's on platforms might not be so accurate enough to generate the
required clock frequency, so instead of erroring out on xvlck frequency
mismatch just warn the user and continue ahead in probe.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/media/i2c/ov5645.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index 52848fff8a08..314760349adf 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -1103,11 +1103,8 @@  static int ov5645_probe(struct i2c_client *client)
 	}
 	/* external clock must be 24MHz, allow 1% tolerance */
 	xclk_freq = clk_get_rate(ov5645->xclk);
-	if (xclk_freq < 23760000 || xclk_freq > 24240000) {
-		dev_err(dev, "external clock frequency %u is not supported\n",
-			xclk_freq);
-		return -EINVAL;
-	}
+	if (xclk_freq < 23760000 || xclk_freq > 24240000)
+		dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n");
 
 	for (i = 0; i < OV5645_NUM_SUPPLIES; i++)
 		ov5645->supplies[i].supply = ov5645_supply_name[i];