[v2] mmc: fix use-after-free issue

Message ID HKAPR02MB429107D62F3E9F86E76AD550E0B40@HKAPR02MB4291.apcprd02.prod.outlook.com
State New
Headers show
Series
  • [v2] mmc: fix use-after-free issue
Related show

Commit Message

彭浩(Richard) May 22, 2020, 9:29 a.m.
The data structure member “rpmb->md” was passed to a call of
 the function “mmc_blk_put” after a call of the function “put_device”.
 Reorder these function calls to keep the data accesses consistent.

Fixes: 1c87f7357849 ("mmc: block: Fix bug when removing RPMB chardev ")
Signed-off-by: Peng Hao <richard.peng@oppo.com>

---
 drivers/mmc/core/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4
________________________________
OPPO

本电子邮件及其附件含有OPPO公司的保密信息,仅限于邮件指明的收件人使用(包含个人及群组)。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件,请立即以电子邮件通知发件人并删除本邮件及其附件。

This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!

Patch

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 8499b56..e6e025c 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -2483,8 +2483,8 @@  static int mmc_rpmb_chrdev_release(struct inode *inode, struct file *filp)
 struct mmc_rpmb_data *rpmb = container_of(inode->i_cdev,
   struct mmc_rpmb_data, chrdev);

-put_device(&rpmb->dev);
 mmc_blk_put(rpmb->md);
+put_device(&rpmb->dev);

 return 0;
 }