From patchwork Fri May 22 09:29:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5b2t5rWpKFJpY2hhcmQp?= X-Patchwork-Id: 210906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=CHARSET_FARAWAY_HEADER, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036B4C433DF for ; Fri, 22 May 2020 09:29:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C69DF206C3 for ; Fri, 22 May 2020 09:29:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=oppoglobal.onmicrosoft.com header.i=@oppoglobal.onmicrosoft.com header.b="ZWCbH8qm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728183AbgEVJ3c (ORCPT ); Fri, 22 May 2020 05:29:32 -0400 Received: from mail-eopbgr1300053.outbound.protection.outlook.com ([40.107.130.53]:14789 "EHLO APC01-HK2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728068AbgEVJ33 (ORCPT ); Fri, 22 May 2020 05:29:29 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BrP0VoZ1HCbY5j+4UDmQnsMroBQ5LQzvkMQAnFc73C6rl7yN1XYXqrJbzfJJpez+ktBtHQUvNkPQxzk6dW3emTZIwAtDG7vyVMBo8jn/3S74OX0VjSyEVWcw58Zax3kjVxmCD3ipiWqh9M2VsgWHjucHyZ1Hyq0KCAWhRL+tBpHXpXseOmIHhUonP6Ps6TZxx/u+6ndWDt/R9Q0T57bwlSXccd8MSJGM1MO+hKf0sZ7MAGFOkK8r87+f5JXHPcEQNfF3RixGOx5EU+a8aBDTaZGgUmpbrgN0QkZLXKKmUTK3DKg6/bvBsxV9GEdwQO0SajbBH7VD8vhR2B+g7Vg7Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uhq+khHEA+fj62144fFShpEsHFBA1gaRwwrk3lr0k1w=; b=EyNPKV23g4SPXQdZ3cERWZ5tpojInj1ptWVPLlDD1ovAEP8Rw+expFb3wf/RUSzOfilWv6DEGm2sfD69enTW8Cg/AbNJuiqTGNomx0FtvbuT8kHv4pknfrLaOBU+w3RQwQzGJvHY3c98XTL65LlFxnIBcWgCLCded38tfZ3pwo1dIzI0dyEed0jE+NBzfO8woBk6oOw5ry2fC7A51FJUw+VwvKRyuhHkYEjMihtW9mIBbim9KYuXVarNBPjzRHYp0f7yEUcdHmm6wF8i91WHRwbnlzToZCy9EnKTf3n4os/BJXK2h/cPSqKq/euemZ3y3IV5obhLku8faF4sxYd2iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppoglobal.onmicrosoft.com; s=selector1-oppoglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uhq+khHEA+fj62144fFShpEsHFBA1gaRwwrk3lr0k1w=; b=ZWCbH8qmR28av3dNymCQuKV35CSF441u/A2LVDb3kIFKdOXJU9RANYlZaa8YTn5tINq8itPGJYb38czu99lIPsznD/ghVLWOfFI2BIh9PDnv7gq7EBuZnN+43UyZtaq/VBFgCaZTB/9+iw9AZYXORE7kfPqYl9o2cV4sJo9g5mw= Received: from HKAPR02MB4291.apcprd02.prod.outlook.com (2603:1096:203:d3::12) by HKAPR02MB4340.apcprd02.prod.outlook.com (2603:1096:203:d4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.26; Fri, 22 May 2020 09:29:25 +0000 Received: from HKAPR02MB4291.apcprd02.prod.outlook.com ([fe80::80ca:c698:988e:a999]) by HKAPR02MB4291.apcprd02.prod.outlook.com ([fe80::80ca:c698:988e:a999%5]) with mapi id 15.20.3021.020; Fri, 22 May 2020 09:29:25 +0000 From: =?gb2312?b?xe26xihSaWNoYXJkKQ==?= To: Ulf Hansson , "Markus.Elfring@web.de" CC: "linux-kernel@vger.kernel.org" , Chaotian Jing , "linux-mmc@vger.kernel.org" Subject: [PATCH v2] mmc: fix use-after-free issue Thread-Topic: [PATCH v2] mmc: fix use-after-free issue Thread-Index: AdYwG1QOySHOrR48TpmU8O/k4aVGOA== Date: Fri, 22 May 2020 09:29:25 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linaro.org; dkim=none (message not signed) header.d=none; linaro.org; dmarc=none action=none header.from=oppo.com; x-originating-ip: [58.252.5.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d83f458e-ebc4-493d-8583-08d7fe329e80 x-ms-traffictypediagnostic: HKAPR02MB4340: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:628; x-forefront-prvs: 04111BAC64 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kcu6bDNZk+RTPb5SmNRsCdb+C5itBAPBOybgy7GpkK1Z+XJK07OGMkpYh3TBRZPI3iPMb1m50eY16pfdGeddzwZ+XCt1r+l31B0s5PlJvn5qKx9LxLgj/XxRlNgBwKcfvaTfiKBw6nBMQZd1gZDBPkebvl8E8ZjnUgjgKTScEBa6IMOs/7EbMkiKUtET09u9/tIxd/tql5HTMnuiKFRFFeGRrobVwnaiGDHP1AlFouUtyUB658IoZr2UE5b6Zu11UHT52gdBMwtGEXLcVf4jgWevVbFecMbP0/mxJuqBFlusKkkJMytgV300NTEoMuvoGoehingBDUZMttobBD9qq+DmJnIgw8ReWu5lhOlozEbs1bZzHkVuyF/ieoMF07HC x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HKAPR02MB4291.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(396003)(376002)(346002)(39860400002)(4326008)(86362001)(110136005)(2906002)(54906003)(316002)(5660300002)(64756008)(186003)(26005)(52536014)(7696005)(478600001)(8936002)(71200400001)(9686003)(66556008)(66476007)(76116006)(66446008)(8676002)(6506007)(66946007)(33656002)(55016002)(85182001)(11606004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: s3wvG4nA/eYNd79i6HRDMmQFi/G8uFeomFJ2Qef15sns9ggti3oH0k8fFH7Lh15NlxGyc7skGhfKTc+AbU0HydzTWR3j4/cHq5OXGc6/bYS2fA3lVoJVyxmPLK1F/VhjlGUxsyhuhlYEYfH3Ue1hohIiqv/B8QCfQlZYzTZ5udJs7rIj356DA+yhbHrJ7/ZbatiJvTCOArm6uboy8UwlaVe3H3p/IsA7YeAI+rYi0qe9L6X0F2wwOUKchenmlEu2sOU1aV16l2QJYq1Lu5ntqsWWo+wQt7OFakV9/V7zL2ATSxg1ZW80JTJvODW0Q2zKPrGc1vZ0G5x8IkCDyKw2Sl3zRtq4K40DCKJnjxUqe54c1fttfx1CGrHGbEC+e1r8f+MDXgHg9Df21F+wH92+of376hpWwtaWKiEPEb49wtoibxhxkhMkcgLS56DH6ADIK41ajLuUiS9qUFqiZlzLHU/Nud7iv50MhWfPUAfVF+Q= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d83f458e-ebc4-493d-8583-08d7fe329e80 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 May 2020 09:29:25.6699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Rzf6c/8JlUB4HWOCyX6sb5gmDbgJQmQ0jWosjo6FLgqNeg+HQhXCjmc5ne39EBVrpKUy2+PZzzlM98LiATmfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HKAPR02MB4340 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The data structure member “rpmb->md” was passed to a call of the function “mmc_blk_put” after a call of the function “put_device”. Reorder these function calls to keep the data accesses consistent. Fixes: 1c87f7357849 ("mmc: block: Fix bug when removing RPMB chardev ") Signed-off-by: Peng Hao --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 ________________________________ OPPO 本电子邮件及其附件含有OPPO公司的保密信息，仅限于邮件指明的收件人使用（包含个人及群组）。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件，请立即以电子邮件通知发件人并删除本邮件及其附件。 This e-mail and its attachments contain confidential information from OPPO, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it! diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 8499b56..e6e025c 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2483,8 +2483,8 @@ static int mmc_rpmb_chrdev_release(struct inode *inode, struct file *filp) struct mmc_rpmb_data *rpmb = container_of(inode->i_cdev, struct mmc_rpmb_data, chrdev); -put_device(&rpmb->dev); mmc_blk_put(rpmb->md); +put_device(&rpmb->dev); return 0; }