From patchwork Fri May 8 07:11:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 212090 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E263C38A2A for ; Fri, 8 May 2020 07:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 053A9221F7 for ; Fri, 8 May 2020 07:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbgEHHM3 (ORCPT ); Fri, 8 May 2020 03:12:29 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:37547 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726009AbgEHHM3 (ORCPT ); Fri, 8 May 2020 03:12:29 -0400 Received: from localhost.localdomain ([93.23.14.114]) by mwinf5d01 with ME id c7CQ2200A2Tev1p037CQVC; Fri, 08 May 2020 09:12:26 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Fri, 08 May 2020 09:12:26 +0200 X-ME-IP: 93.23.14.114 From: Christophe JAILLET To: milo.kim@ti.com, sre@kernel.org, anton.vorontsov@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] power: supply: lp8788: Fix an error handling path in 'lp8788_charger_probe()' Date: Fri, 8 May 2020 09:11:50 +0200 Message-Id: <20200508071150.204974-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org In case of error, resources allocated in 'lp8788_setup_adc_channel()' must be released. Add a call to 'lp8788_release_adc_channel()' as already done in the remove function. Fixes: 98a276649358 ("power_supply: Add new lp8788 charger driver") Signed-off-by: Christophe JAILLET --- drivers/power/supply/lp8788-charger.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c index 84a206f42a8e..641815eb24bc 100644 --- a/drivers/power/supply/lp8788-charger.c +++ b/drivers/power/supply/lp8788-charger.c @@ -719,13 +719,17 @@ static int lp8788_charger_probe(struct platform_device *pdev) ret = lp8788_psy_register(pdev, pchg); if (ret) - return ret; + goto err_release_adc_channel; ret = lp8788_irq_register(pdev, pchg); if (ret) dev_warn(dev, "failed to register charger irq: %d\n", ret); return 0; + +err_release_adc_channel: + lp8788_release_adc_channel(pchg); + return ret; } static int lp8788_charger_remove(struct platform_device *pdev)