diff mbox

[0/2] GDB process record and reverse debugging improvements for arm*-linux*

Message ID CANW4E-3+-9FTB2C9tYO42CAV7mZeUP8ayPR+3sH1F5bweJM_7Q@mail.gmail.com
State Superseded
Headers show

Commit Message

Omair Javaid Oct. 24, 2013, 12:09 a.m. UTC 
Hi,
This patch series improves gdb process record and reverse debugging
capabilities for arm targets. There are three patches in the current
list and they divided as below:
Patch 0) Enables gdb.reverse testsuite for arm and also enables
linux-record for arm by making changes to configure.tgt file.
Patch 1) Adds support in arm process record code to decode system call
and various types of thumb32 instructions.
Patch 2) Includes changes required to implement system call
instruction recording on arm targets.

This patch has been tested on arm ARMv7 Processor rev 4 (v7l). Also
regression testing has been performed on a x86_64 machine.

gdb.reverse Testsuite Results

(ARM-Native Configuration)
Previous: 508 Pass
With This Patch: 2211 Pass

(ARM-Remote Configuration)
Previous: 501 Pass
With This Patch: 2193 Pass

== PATCH 0 ==

This patch adds a news entry about improved process record-replay on
arm*-linux* targets.
It also adds linux-record.o to gdb_target_obs in configure.tgt and
enables gdb.reverse testsuite for arm*-linux* targets.

gdb:

2013-10-24  Omair Javaid  <omair.javaid@linaro.org>

* NEWS: Add note on improved process record-replay
on arm*-linux* targets.
* configure.tgt: Add linux-record.o to gdb_target_obs.

gdb/testsuite/lib:

2013-10-24  Omair Javaid  <omair.javaid@linaro.org>

* gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets.

Comments

Yao Qi Oct. 24, 2013, 1:40 a.m. UTC | #1 
On 10/24/2013 08:09 AM, Omair Javaid wrote:
> gdb/testsuite/lib:

Remove "/lib" ....

>
> 2013-10-24  Omair Javaid<omair.javaid@linaro.org>
>
> * gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets.

and add "lib/" before "gdb.exp:".  Since the ChangeLog file is located 
in gdb/testsuite instead of gdb/testsuite/lib.


> RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
> retrieving revision 1.250
> diff -u -p -r1.250 gdb.exp
> --- gdb/testsuite/lib/gdb.exp 18 Oct 2013 20:40:03 -0000 1.250
> +++ gdb/testsuite/lib/gdb.exp 23 Oct 2013 20:34:49 -0000
> @@ -1774,7 +1774,8 @@ proc supports_process_record {} {
>    return [target_info gdb,use_precord]
>       }
>
> -    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
> +    if { [istarget "arm*-*-*"] || [istarget "x86_64-*-linux*"]

It should be arm*-*-linux* ...

> +         || [istarget "i\[34567\]86-*-linux*"] } {
>    return 1
>       }
>
> @@ -1789,7 +1790,8 @@ proc supports_reverse {} {
>    return [target_info gdb,can_reverse]
>       }
>
> -    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
> +    if { [istarget "arm*-*-*"] || [istarget "x86_64-*-linux*"]
> +         || [istarget "i\[34567\]86-*-linux*"] } {
>    return 1
>       }

... and here.
Yao Qi Oct. 24, 2013, 1:42 a.m. UTC | #2 
On 10/24/2013 08:09 AM, Omair Javaid wrote:
> --- gdb/NEWS 11 Oct 2013 13:51:26 -0000 1.622
> +++ gdb/NEWS 23 Oct 2013 20:34:42 -0000
> @@ -3,6 +3,12 @@
>
>   *** Changes since GDB 7.6
>
> +* Improved support of process record-replay and reverse debugging on
> +  arm*-linux* targets.
> +
> +Support for thumb32 instructions and syscall recording has been added.

This change is user visible...

> +gdb/testsuite/gdb.reverse is now enabled for arm*-linux* targets.
> +

while this is not.  This line is not necessary in NEWS.
diff mbox

Patch

Index: gdb/NEWS
===================================================================
RCS file: /cvs/src/src/gdb/NEWS,v
retrieving revision 1.622
diff -u -p -r1.622 NEWS
--- gdb/NEWS 11 Oct 2013 13:51:26 -0000 1.622
+++ gdb/NEWS 23 Oct 2013 20:34:42 -0000
@@ -3,6 +3,12 @@ 

 *** Changes since GDB 7.6

+* Improved support of process record-replay and reverse debugging on
+  arm*-linux* targets.
+
+Support for thumb32 instructions and syscall recording has been added.
+gdb/testsuite/gdb.reverse is now enabled for arm*-linux* targets.
+
 * GDB now supports Fission DWP file format version 2.
   http://gcc.gnu.org/wiki/DebugFission

Index: gdb/configure.tgt
===================================================================
RCS file: /cvs/src/src/gdb/configure.tgt,v
retrieving revision 1.281
diff -u -p -r1.281 configure.tgt
--- gdb/configure.tgt 1 Oct 2013 13:21:17 -0000 1.281
+++ gdb/configure.tgt 23 Oct 2013 20:34:42 -0000
@@ -89,7 +89,7 @@  arm*-wince-pe | arm*-*-mingw32ce*)
 arm*-*-linux*)
  # Target: ARM based machine running GNU/Linux
  gdb_target_obs="arm-tdep.o arm-linux-tdep.o glibc-tdep.o \
- solib-svr4.o symfile-mem.o linux-tdep.o"
+ solib-svr4.o symfile-mem.o linux-tdep.o linux-record.o"
  build_gdbserver=yes
  ;;
 arm*-*-netbsd* | arm*-*-knetbsd*-gnu)
Index: gdb/testsuite/lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.250
diff -u -p -r1.250 gdb.exp
--- gdb/testsuite/lib/gdb.exp 18 Oct 2013 20:40:03 -0000 1.250
+++ gdb/testsuite/lib/gdb.exp 23 Oct 2013 20:34:49 -0000
@@ -1774,7 +1774,8 @@  proc supports_process_record {} {
  return [target_info gdb,use_precord]
     }

-    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
  return 1
     }

@@ -1789,7 +1790,8 @@  proc supports_reverse {} {
  return [target_info gdb,can_reverse]
     }

-    if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
+    if { [istarget "arm*-*-*"] || [istarget "x86_64-*-linux*"]
+         || [istarget "i\[34567\]86-*-linux*"] } {
  return 1
     }