[06/22] fnic: check for started requests in fnic_wq_copy_cleanup_handler()

Message ID 20200625140124.17201-7-hare@suse.de
State Superseded
Headers show
  • [01/22] scsi: drop gdth driver
Related show

Commit Message

Hannes Reinecke June 25, 2020, 2:01 p.m.
fnic_wq_copy_cleanup_handler() is using scsi_host_find_tag() to
map id to a scsi command. However, as per discussion on the mailinglist
scsi_host_find_tag() might return a non-started request, so we need
to check the returned command with blk_mq_request_started() to avoid
the function tripping over a non-initialized command.

Signed-off-by: Hannes Reinecke <hare@suse.de>
 drivers/scsi/fnic/fnic_scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 04879ced2835..13db2181d3fd 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -1464,7 +1464,7 @@  void fnic_wq_copy_cleanup_handler(struct vnic_wq_copy *wq,
 	sc = scsi_host_find_tag(fnic->lport->host, id);
-	if (!sc)
+	if (!sc || !blk_mq_request_started(sc->request))
 	io_lock = fnic_io_lock_hash(fnic, sc);