From patchwork Fri Nov 8 16:34:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Newton X-Patchwork-Id: 21427 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9E7B1244F2 for ; Fri, 8 Nov 2013 16:34:50 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id i4sf7579438oah.5 for ; Fri, 08 Nov 2013 08:34:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=RHGKOM58gNQrB08e/APX6W8+6BTExah+4fKtiSs16s0=; b=M4Htcfo5hgRRXu8XYNn0wSVh2q0xFaVoEK9xE8Hq5KIBi2NHv7Jpenz+cBcq1uhrzA zUPj6PJTN8AkBTThN1pKpUD+20GKklj12PhtmZtX5IdEkEWrFrABtiAQrvUjNAjkW+F+ vpo4eyAnc1ZouecsP8otIJVqi0iXIafgQB5pehJH/4TO8ax3I6U9SeYomQViHz/q+HWM cy8REuKZ82GizLTGwRXFDKCeXejYEI5SiKUX7hRE4UpE6Z1LXOJR/jd96mFbooFlvyEa m/MTIhuz51gsZb3Gc+og3IyIOw6SlckNx+fBzM/5CLqQxR5ZeqFrqxgkoE+wYZ0bPe7l uuxg== X-Gm-Message-State: ALoCoQnHQmbSEaWwehGR+d3MPP96dXI+RDpz1igNf2Yrqwbys6A1F+xSlNpdhVvcUfR16J5j3VyF X-Received: by 10.182.213.5 with SMTP id no5mr4829918obc.15.1383928489451; Fri, 08 Nov 2013 08:34:49 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.30.37 with SMTP id p5ls1676987qeh.51.gmail; Fri, 08 Nov 2013 08:34:49 -0800 (PST) X-Received: by 10.221.37.9 with SMTP id tc9mr298074vcb.39.1383928489226; Fri, 08 Nov 2013 08:34:49 -0800 (PST) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id o6si4331106vcz.79.2013.11.08.08.34.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Nov 2013 08:34:49 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id ik5so1555140vcb.16 for ; Fri, 08 Nov 2013 08:34:49 -0800 (PST) X-Received: by 10.220.159.4 with SMTP id h4mr4974786vcx.1.1383928488936; Fri, 08 Nov 2013 08:34:48 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp43226vcz; Fri, 8 Nov 2013 08:34:48 -0800 (PST) X-Received: by 10.194.11.38 with SMTP id n6mr13089972wjb.25.1383928488051; Fri, 08 Nov 2013 08:34:48 -0800 (PST) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx.google.com with ESMTPS id ek16si1318814wic.58.2013.11.08.08.34.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Nov 2013 08:34:48 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.182 is neither permitted nor denied by best guess record for domain of will.newton@linaro.org) client-ip=74.125.82.182; Received: by mail-we0-f182.google.com with SMTP id t61so2225413wes.13 for ; Fri, 08 Nov 2013 08:34:47 -0800 (PST) X-Received: by 10.180.91.115 with SMTP id cd19mr993462wib.31.1383928487397; Fri, 08 Nov 2013 08:34:47 -0800 (PST) Received: from localhost.localdomain (cpc6-seac21-2-0-cust453.7-2.cable.virginm.net. [82.1.113.198]) by mx.google.com with ESMTPSA id ft19sm7024698wic.5.2013.11.08.08.34.45 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Nov 2013 08:34:46 -0800 (PST) Message-ID: <527D12A4.6070109@linaro.org> Date: Fri, 08 Nov 2013 16:34:44 +0000 From: Will Newton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: Patch Tracking Subject: [PATCH] gdb/arm-tdep.c: Remove "Infinite loop detected" error message. X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: will.newton@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Since as far back as the beginning of the sourceware repository the ARM port has printed an error "Infinite loop detected" when the next_pc calculated is the same as the current one, for example when encountering a branch to the current PC address. This causes the test gdb.base/random-signal.exp as the error message is not expected. I have not been able to find a good reason for the message to be here so remove it and let the test pass. gdb/ChangeLog: 2013-11-08 Will Newton * arm-tdep.c (arm_get_next_pc): Remove "Infinite loop detected" error message. --- gdb/arm-tdep.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 1ed21ea..035894c 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -4970,17 +4970,9 @@ arm_get_next_pc (struct frame_info *frame, CORE_ADDR pc) CORE_ADDR nextpc; if (arm_frame_is_thumb (frame)) - { - nextpc = thumb_get_next_pc_raw (frame, pc); - if (nextpc == MAKE_THUMB_ADDR (pc)) - error (_("Infinite loop detected")); - } + nextpc = thumb_get_next_pc_raw (frame, pc); else - { - nextpc = arm_get_next_pc_raw (frame, pc); - if (nextpc == pc) - error (_("Infinite loop detected")); - } + nextpc = arm_get_next_pc_raw (frame, pc); return nextpc; }