diff mbox series

[v6,6/9] clk: stm32: Fix ltdc's clock turn off by clk_disable_unused() after kernel startup

Message ID 1590564453-24499-7-git-send-email-dillon.minfei@gmail.com
State New
Headers show
Series Enable ili9341 and l3gd20 on stm32f429-disco | expand

Commit Message

Dillon Min May 27, 2020, 7:27 a.m. UTC 
From: dillon min <dillon.minfei@gmail.com>

stm32's clk driver register two ltdc gate clk to clk core by
clk_hw_register_gate() and clk_hw_register_composite()

first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use.
second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver

both of them point to the same offset of stm32's RCC register. after
kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]'
is no one to use. but, actually 'stm32f429_aux_clk[]' is in use.

Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock")
Signed-off-by: dillon min <dillon.minfei@gmail.com>
---

Changes since V5:
separate '[PATCH v5 5/8]' to two, add Fixes tags.

 drivers/clk/clk-stm32f4.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dillon Min March 10, 2021, 11:43 a.m. UTC | #1 
still need more expert to review, so just a gentle ping for this patch

On Wed, May 27, 2020 at 4:35 PM Stephen Boyd <sboyd@kernel.org> wrote:
>

> Quoting dillon.minfei@gmail.com (2020-05-27 00:27:30)

> > From: dillon min <dillon.minfei@gmail.com>

> >

> > stm32's clk driver register two ltdc gate clk to clk core by

> > clk_hw_register_gate() and clk_hw_register_composite()

> >

> > first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use.

> > second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver

> >

> > both of them point to the same offset of stm32's RCC register. after

> > kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]'

> > is no one to use. but, actually 'stm32f429_aux_clk[]' is in use.

> >

> > Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock")

> > Signed-off-by: dillon min <dillon.minfei@gmail.com>

> > ---

>

> Acked-by: Stephen Boyd <sboyd@kernel.org>
diff mbox series

Patch

diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index 42ca2dd86aea..fa62e990c539 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -129,7 +129,6 @@  static const struct stm32f4_gate_data stm32f429_gates[] __initconst = {
 	{ STM32F4_RCC_APB2ENR, 20,	"spi5",		"apb2_div" },
 	{ STM32F4_RCC_APB2ENR, 21,	"spi6",		"apb2_div" },
 	{ STM32F4_RCC_APB2ENR, 22,	"sai1",		"apb2_div" },
-	{ STM32F4_RCC_APB2ENR, 26,	"ltdc",		"apb2_div" },
 };
 
 static const struct stm32f4_gate_data stm32f469_gates[] __initconst = {