| Message ID | 20200625165210.14904-1-wsa@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC] iwlwifi: yoyo: don't print failure if debug firmware is missing | expand |
Wolfram Sang <wsa@kernel.org> writes: > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: >> Missing this firmware is not fatal, my wifi card still works. Even more, >> I couldn't find any documentation what it is or where to get it. So, I >> don't think the users should be notified if it is missing. If you browse >> the net, you see the message is present is in quite some logs. Better >> remove it. >> >> Signed-off-by: Wolfram Sang <wsa@kernel.org> >> --- > > Any input on this? Or people I should add to CC? This was discussed on another thread: https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net Unless Intel folks object I'm planning to take this to wireless-drivers-next. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote: > Wolfram Sang <wsa@kernel.org> writes: > > > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote: > >> Missing this firmware is not fatal, my wifi card still works. Even more, > >> I couldn't find any documentation what it is or where to get it. So, I > >> don't think the users should be notified if it is missing. If you browse > >> the net, you see the message is present is in quite some logs. Better > >> remove it. > >> > >> Signed-off-by: Wolfram Sang <wsa@kernel.org> > >> --- > > > > Any input on this? Or people I should add to CC? > > This was discussed on another thread: > > https://lkml.kernel.org/r/87mu3magfp.fsf@tynnyri.adurom.net > > Unless Intel folks object I'm planning to take this to > wireless-drivers-next. Cool, thanks for the heads up!
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c index 7987a288917b..f180db2936e3 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c @@ -468,7 +468,7 @@ void iwl_dbg_tlv_load_bin(struct device *dev, struct iwl_trans *trans) if (!iwlwifi_mod_params.enable_ini) return; - res = request_firmware(&fw, "iwl-debug-yoyo.bin", dev); + res = firmware_request_nowarn(&fw, "iwl-debug-yoyo.bin", dev); if (res) return;
Missing this firmware is not fatal, my wifi card still works. Even more, I couldn't find any documentation what it is or where to get it. So, I don't think the users should be notified if it is missing. If you browse the net, you see the message is present is in quite some logs. Better remove it. Signed-off-by: Wolfram Sang <wsa@kernel.org> --- This is only build tested because I wanted to get your opinions first. I couldn't find any explanation about yoyo, so I am entering unknown territory here. drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)