From patchwork Wed Apr 15 16:11:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216001 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3249EC2BA19 for ; Wed, 15 Apr 2020 16:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0900D20656 for ; Wed, 15 Apr 2020 16:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="hVcCur3O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410286AbgDOQMw (ORCPT ); Wed, 15 Apr 2020 12:12:52 -0400 Received: from mail-eopbgr700077.outbound.protection.outlook.com ([40.107.70.77]:38433 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2410260AbgDOQMr (ORCPT ); Wed, 15 Apr 2020 12:12:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6182+L9AyRlyyXJW+3iFVmhhTKq/5SFWxCkJVeoBNPSBxYgwVqKYrvJh47jb8sXkNhDVFRj8LpVG9CcQ34pz1kgLxKdHWD9eUqLUD6juJmG3G9LXYSCI4s7045mIMPP1Y+JQN7xa5DghEYwcREtWZp9XqkvSgE4rxy7SefmkbPlvtlaYLo8oCK40UP3DnZ//nHVOiy84V+rxZTg6P2mdvcoMPcd5I7pakSGTjIO1COkqxtKdet1CITtKfDXETyzcCvoeOl/Z0JSeYotPZqogcd0dF1rO9ZMx/gB6MD5+1bCnMdP3yGEHRvVhb8WPiZEL2wxGgpnBxDbOLhMqYoftA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GgTYWIabQecCI7PUZfPoM9nNc6ZjdlRRo9IajxQppw=; b=R/PbykHEmbSjhK7qUAvRBPi5KlYfjNBWiY7u/2St3JGtJnb7eGbgLcXGUh5kTaxdSamHrm7O0jTWO/FQaaOWSdnaWcm9Zn6EUBBggLEuD1LiDWguSybaf3vgbSgDqsH/7e0oEkT186GEcolJvT630p7L17YV4a9zZL8UuZVvd1o/dURT8S6kND4YZ7mCvslRDgTEd+b/VY6x3qKCapFYAUshTTlXvY/Q2+fNKui56gpNmkhnI/Wi18ALd+yRXWBeMnZHgQztUccDNu9NLPHtHwmUeeQ/+V2IL1E5+tp/+1FZgL2oaDpX1fPc6zWCKUlNykBB7cUjYoogUjqVLJWUtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/GgTYWIabQecCI7PUZfPoM9nNc6ZjdlRRo9IajxQppw=; b=hVcCur3Om5eSyV4o5FNHipaMDP1SuXO+sSSyfMOWvgPUElf/Pc95BoLi/FhGCblAqiePKbIKXsJOsYEvNXF/rfTfX/PSe4bCIFbc+PRBXfniWy3dJlVAaRbX14DyliiSuk2WDcSG7FccpkAAmFa3CaOf1Lx9QrPYyBLsxwGztVM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:35 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:35 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/20] staging: wfx: stop changing filtering rule in wfx_hw_scan() Date: Wed, 15 Apr 2020 18:11:36 +0200 Message-Id: <20200415161147.69738-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:32 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b14572a-2c9e-4600-78dc-08d7e157cf09 X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(4744005)(5660300002)(2906002)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(6486002)(6506007)(66946007); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jh12hm997oRmI0gUR2Ph5zCOBwwWno6Jz+Le+QSLbxBefb9UPf/6j9QvqHuQCSCfP8dO6+YpvNLECrXmAGD3X8kUnsrxcA0IwqaqvZI0eWr+IQZoWed+aDbszb7JYE5HZ2rz4M53UzdlGKgeuwsO3UJ52pZy/dVsUii9mHMMj+vVUTfEbXpdEyuxPBMIi2N9NU+ZklB7JEyDNag9LcevODA6AXH5w2/J0+R/lVrzk68EJhbeNexuwcydnbl5+DLFokLlkaJaGlBPmqZ8inQvt6RbLmh146UbZeU0gwAMXzYGRFsGJFHxYJ9wqBXJlOGeEjQOtm4TmHlOgLAU5cww78hZnWsbcl02WomTChGzNbKk6agXO0yoqm4kgZng+LanMESthMi3orFaV4c9US7N07ZMx7iMkW2IEsHBXn4/60OTLXhTg016G0W4sJdXfn4p X-MS-Exchange-AntiSpam-MessageData: kO8pTUS0KVhMRgpMuMUbKeWjalWIf9S2qBTP1Tl8Es6d8Tj0CaiQt+Hu3mVwimV0xSzWIyPRONaulM9cDgkwWWkN5SyyhLYLPe7GPCRx3hDfS7v5KT429ZeSqgK7jFFn66o7KfZ6SVsawActD4vGQ5DiBrAZOzVHZjyjXUtbMN+wu34gnZS7TmElfIFH2Lx8+iWP8HsvG6d9hrYu7GbNNw== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b14572a-2c9e-4600-78dc-08d7e157cf09 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:35.0922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ApX7y/UCqVb9mBWkvKwvd07U7QfxSVFVbzv61/E7prQuUgIFlDzjKfMaie08JpUw1nF+xndp3KUdXSHs8z/2Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller It is not very clear why driver ask to firmware to stop filtering probe request during scan. It is particularly weird because scan is not supported in AP mode. In add, it does not restore previous filtering state after scanning. It seems to be a mistake and should be dropped. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/scan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/scan.c b/drivers/staging/wfx/scan.c index 0c7f4eef045c..276fdacd7143 100644 --- a/drivers/staging/wfx/scan.c +++ b/drivers/staging/wfx/scan.c @@ -89,7 +89,6 @@ void wfx_hw_scan_work(struct work_struct *work) mutex_lock(&wvif->wdev->conf_mutex); mutex_lock(&wvif->scan_lock); update_probe_tmpl(wvif, &hw_req->req); - wfx_fwd_probe_req(wvif, true); chan_cur = 0; do { ret = send_scan_req(wvif, &hw_req->req, chan_cur);