From patchwork Fri Apr 10 13:32:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 216044 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7113EC2BB1D for ; Fri, 10 Apr 2020 13:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E6012082D for ; Fri, 10 Apr 2020 13:35:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="ZsaMrTm1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgDJNey (ORCPT ); Fri, 10 Apr 2020 09:34:54 -0400 Received: from mail-dm6nam12on2082.outbound.protection.outlook.com ([40.107.243.82]:31903 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726801AbgDJNdR (ORCPT ); Fri, 10 Apr 2020 09:33:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTHjElsALF1Gt0AhXSaoGIaUGY+fiCY0amaedpjphvjxfDirnFyKtelV7eswOAmFREHnQYsr5YFhxNAOFZsCBM18fagXkQY9p4mkw3qbMb29KIDW5ylGyfE64rHoMgmOhH9REqRXe1St9+reAttbZrSKtUWTaPMIY0+tLjkHD9EhdXtuD/JwtxQeHkuV4Cvvc1Vase/rPb+eizcbeuVZa5ecoprQAeerIFwHD+uOr3nn9I36DqHOOR+LTxGNpcy9lJkmLA0QrQ4cGsERYhCZV2a6/sv85nwzRpiJfWNQ97qKstv5hsN0xT3fsAjli6YhWsmjsmubUlwQ6EnLKSQvuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIZUy/h6rYzymHnG1QdL8KvuWbTsGwdnnb/NhWHB+MY=; b=EAzjcKlXqnPSEPMQA4rZM6PJvgklml498lVLyMfL3PzfAJgsq71G7lpXN42vcMHgrgqPLWMh57vskawM8nBpr+dae0KnzicS83dHKlsjecTaW0cIC+2IMRWLjdLnrRzDGQ7nixsdlknrbDYGuA4msELxRg1ceXkeAZz3SQ1EyIa+Nn1acivysCPvZgBgUJAimWKtuL271EP/XQRhBLsPNWIbU5J2dCHvAj1A1WoM4vV1ls5RBf7jEtgci06BbeNAHvSHOAbC+ikjWdBd+U2mb3iHQfPZoS2bOMfZsVQoVn8BidOZhAuuscA+qGI7g2FfnSSftraOZv4jlf3qmLs3ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gIZUy/h6rYzymHnG1QdL8KvuWbTsGwdnnb/NhWHB+MY=; b=ZsaMrTm1F05fpJyefqKxmjCE9to8EBCNIGp3BItNJaykdrRCMHr8pzf4dspiAgVqXpAyJiZanl4y41KnjlW7kNCmMVtToUI3KATZaCJjp22MYsiE0tDhikErXRKBKbtOMmHxtJ71pBljuSPbjqS6aAtAsNmNe1Fvi6Tca73vdWg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:12 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:12 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 07/19] staging: wfx: remove useless call to wfx_tx_flush() Date: Fri, 10 Apr 2020 15:32:27 +0200 Message-Id: <20200410133239.438347-8-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:10 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c02af5d3-a0a2-425c-b035-08d7dd53b71e X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:169; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(4744005)(6666004)(8936002)(4326008)(52116002)(66574012)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2nN0t1b3gOWheFtt7aWWG9QQUw72G3p8iKFH39lFEHWBlQ0b7VWhxSotjLzPhUaJokeeq7HDA07/IhFBNwY20d/FmvpzWIw7pEixhjysQrLO2SrKJMYZNGQfwDo+mz2KMzMu80N9A2Oacs3Kl+EFEGgJf+eerKeX6fSVIjvi94u97odJn1yw/EGe8GZcjQa0a2NXx7WsKOKYb4T2UIfEAwX5z25dfrWW/RgR16eyNWgRx/zny3TKs76sM1rm8WjUyaiL0N3+05kmtBDG/Qm+glIpNWwzeuKzXPpWSr6QXxXuG9P1TIVqj8LYo1x2cCd2/ugrPqs4QBwT75erP3QKYzZ8E7fwSDVvakiO4+thGv2ukbxm9yqwPnIn0KdhcASIpkHpk0hoYB4eeHFHAMejt/Peyu2tCcbIZcFNAGaEHOa9HFKoNZjoFsO1y8IT4FtH X-MS-Exchange-AntiSpam-MessageData: 6IbbNJoRZpQUaDOUszOkW7jVPdJ220NNGJp/Uh8BeJerbndm2hHqkFSDL3xKQGXwarmc2m1ZDgRlMPoKf2OqvFhgEeoqzgtSz2LwhFzHQ9NrIj49QGfPQjnuO2NzciPvX40ZfeYYt6MGkOqY68ZgIVuRl47EFTrK18MEAZ/BxIE7d3NIBEVrr/HVff1ACkDiQirP3VpAoP6PKXlS2QzsvQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: c02af5d3-a0a2-425c-b035-08d7dd53b71e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:12.3538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qb/wJvDMCnNregBVOfwizXOCpZS4lHPbsir4Rne4WoUkVFyI5AAn8B487uNPuGZn4q1Kug6hXXpQHNc4EYox6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller wfx_do_join() calls wfx_tx_lock_flush() ate beginning of the function. Therefore, the subsequent call to wfx_tx_flush() is useless. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index acbbc3a44733..7693ce22f300 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -493,8 +493,6 @@ static void wfx_do_join(struct wfx_vif *wvif) } rcu_read_unlock(); - wfx_tx_flush(wvif->wdev); - if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF);