qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE

Message ID 20200624101302.8316-1-colin.king@canonical.com
State New
Headers show
  • qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
Related show

Commit Message

Colin King June 24, 2020, 10:13 a.m.
From: Colin Ian King <colin.king@canonical.com>

The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
enum dbg_status however there is a missing corresponding entry for
this in the array s_status_str. This causes an out-of-bounds read when
indexing into the last entry of s_status_str.  Fix this by adding in
the missing entry.

Addresses-Coverity: ("Out-of-bounds read").
Fixes: 2d22bc8354b1 ("qed: FW debug features")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
 drivers/net/ethernet/qlogic/qed/qed_debug.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
index 57a0dab88431..81e8fbe4a05b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
@@ -5568,7 +5568,8 @@  static const char * const s_status_str[] = {
 	"The filter/trigger constraint dword offsets are not enabled for recording",
+	"No matching framing mode",
 	"Error reading from VFC",