From patchwork Wed Nov 27 23:31:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Franz X-Patchwork-Id: 21825 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 764AB23FD2 for ; Wed, 27 Nov 2013 23:32:14 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id r10sf19497012pdi.6 for ; Wed, 27 Nov 2013 15:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=miggL5sL7ggq/EK/QqiDvXkAVzzc6eSPLx8n+BTX7Bs=; b=RAfzhe+R5mXLXyF2ulCSJyJkGmvQwFMk6yUro95hCQTpNCCWhIOxQsQCIKH9GdBpTV qljDG+LtyjAfKtHjjq6A5OI3kCFBX7nhVhRqWKaCoy3VY+MJf+YM9LYl8GrihDJVEpOY hXG01A3jONP1PdtGauiiIwAVBogEVR+9Pa7nk2cd6GWqXeR3USBGUBY+fwdEb+kL9F89 DLnIqx0Fp+I1EPjdEC1u6zTFWAVlLPWohCF+Ym4C2RRdLJffYu2dMupS1ns5Pxbe9EBM /tKhSvwzKhj5/g7y7NS1p/BMHBkBZiz6Sb0092lIdDYNg/Nhx413k5Ahnta6fJV60BXD hr4Q== X-Gm-Message-State: ALoCoQmQmmK2yX8wK00K6JQRrqma7fUiFg0dK6HMqXOgr1gqF7Dfa9dyLeHjLw6rg5wZcm1l11cL X-Received: by 10.66.142.11 with SMTP id rs11mr5125884pab.37.1385595133586; Wed, 27 Nov 2013 15:32:13 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.38.36 with SMTP id d4ls1463797qek.7.gmail; Wed, 27 Nov 2013 15:32:13 -0800 (PST) X-Received: by 10.52.76.36 with SMTP id h4mr1480765vdw.46.1385595133434; Wed, 27 Nov 2013 15:32:13 -0800 (PST) Received: from mail-vb0-f47.google.com (mail-vb0-f47.google.com [209.85.212.47]) by mx.google.com with ESMTPS id a6si21749661vdp.0.2013.11.27.15.32.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Nov 2013 15:32:13 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.47 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.47; Received: by mail-vb0-f47.google.com with SMTP id x11so5316601vbb.20 for ; Wed, 27 Nov 2013 15:32:13 -0800 (PST) X-Received: by 10.58.217.169 with SMTP id oz9mr124903vec.42.1385595133354; Wed, 27 Nov 2013 15:32:13 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp24576vcz; Wed, 27 Nov 2013 15:32:13 -0800 (PST) X-Received: by 10.42.232.206 with SMTP id jv14mr7304068icb.52.1385595132842; Wed, 27 Nov 2013 15:32:12 -0800 (PST) Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by mx.google.com with ESMTPS id e2si29404195igo.42.2013.11.27.15.32.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Nov 2013 15:32:12 -0800 (PST) Received-SPF: neutral (google.com: 209.85.223.170 is neither permitted nor denied by best guess record for domain of roy.franz@linaro.org) client-ip=209.85.223.170; Received: by mail-ie0-f170.google.com with SMTP id qd12so13265199ieb.1 for ; Wed, 27 Nov 2013 15:32:12 -0800 (PST) X-Received: by 10.42.62.196 with SMTP id z4mr7270619ich.49.1385595132590; Wed, 27 Nov 2013 15:32:12 -0800 (PST) Received: from rfranz-v430.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPSA id p5sm41764439igj.10.2013.11.27.15.32.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Nov 2013 15:32:12 -0800 (PST) From: Roy Franz To: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, matt.fleming@intel.com, linux@arm.linux.org.uk Cc: leif.lindholm@linaro.org, grant.likely@linaro.org, dave.martin@arm.com, msalter@redhat.com, patches@linaro.org, Roy Franz Subject: [PATCH V5 5/6] Disable stack protection for decompressor/stub Date: Wed, 27 Nov 2013 15:31:54 -0800 Message-Id: <1385595115-21488-6-git-send-email-roy.franz@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1385595115-21488-1-git-send-email-roy.franz@linaro.org> References: <1385595115-21488-1-git-send-email-roy.franz@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: roy.franz@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.47 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The ARM decompressor/EFI stub do not implement the functions (__stack_chk_guard_setup, etc) that are required for support of stack protection. The actual enablement of stack protection is controlled by heuristics in GCC, which the code added for the EFI stub triggers when CONFIG_STACKPROTECTOR is set. Even with CONFIG_STACKPROTECTOR set, the decompressor was never compiled with stack protection actually enabled. Adding -fno-stack-protector to the decompressor/stub build keeps it building without stack protection as it has always been built. The x86 decompressor/stub is also built with -fno-stack-protector. Signed-off-by: Roy Franz --- arch/arm/boot/compressed/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index c0c7fee..7974791 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile @@ -132,7 +132,7 @@ ORIG_CFLAGS := $(KBUILD_CFLAGS) KBUILD_CFLAGS = $(subst -pg, , $(ORIG_CFLAGS)) endif -ccflags-y := -fpic -mno-single-pic-base -fno-builtin -I$(obj) +ccflags-y := -fpic -mno-single-pic-base -fno-builtin -fno-stack-protector -I$(obj) asflags-y := -DZIMAGE # Supply kernel BSS size to the decompressor via a linker symbol.