From patchwork Tue May 5 12:37:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 219880 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAD3C47247 for ; Tue, 5 May 2020 12:40:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B52320735 for ; Tue, 5 May 2020 12:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="cmqiCfJL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbgEEMiU (ORCPT ); Tue, 5 May 2020 08:38:20 -0400 Received: from mail-eopbgr680041.outbound.protection.outlook.com ([40.107.68.41]:21169 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728820AbgEEMiR (ORCPT ); Tue, 5 May 2020 08:38:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N7goQeyxUWFKBEGlfQ+yiFkFW4mI8J+PpogtRXO82IQR0Wp6L6OSfDepiel1GUfI7xTGdD0601uuASoZyudizsKQh5e6v6ItxpD2j8QfKqSnQGZWj5fc7B7xt4OGmo1TYoVHmOrF3GtvxDWK48TvdmxIl7JX2si/ih7zpyj2nNjMxczzSPqkaxz6lgbdOi0bZi4vjv8feqTAZEaZO/+TZKz/emrUllbcZFc0UZSQvKfnrBmbcQecCyKdeElbgZLO30dvVBFV2mdh30ySTPZPqxTy1IV0uCwCusbEltUMkt5MOOLK6InUURYPW8xmdsxtDCzg6IUWHjfF9k/1TkA9jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kg0fpV6J8wbKQWde4/vMX8w/mrW9jr6sKX+MkbzvZ0c=; b=hzKwesXYc5zAbYzt54aNT6Q8ASYRzueQZsCrfXWxt15vY+6EOoRN+aC64uYWlnd/xeVeBtf3NAZXLa4S2n5hvOhtdEnBjCccka+QCyNpoERsd8qGh7RUyrKHDgmiUYc2hlzI7Fsvl+R2r8oHs+aJv2Wi3U3XaDmSiveUjz/LzbwQMymz6CBq58M78SWffe5R7okvwcV0cKFig82Tv7xHa+WjrmEUmDiiizpl0etkc1ajOZkWvXaYjP3jgNjEBJmbgmYQEzawv5Sl8hFKy4zSzIhgM9Ai83sPLqBxvpdOUVP6xVZS9/Y431cFL8SwcwAWgelQDl8rucDJ0SfU4MYhHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kg0fpV6J8wbKQWde4/vMX8w/mrW9jr6sKX+MkbzvZ0c=; b=cmqiCfJLahr+WYRpRKksawian0jL4NW8BsX4bMQ8u8SN3438lcCaQpwZVrOAOljncQOEmyG5i3ds42l9pxG8Lpyeco1tQq0aV2zPMYrodr48nYrz5X/f2Gfsg1CZDLhRYzFRwn7ZJikceVPaoV2kb68idOvuHzv/jSTZd7u306g= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1824.namprd11.prod.outlook.com (2603:10b6:300:110::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19; Tue, 5 May 2020 12:38:13 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2958.030; Tue, 5 May 2020 12:38:13 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 01/15] staging: wfx: add support for hardware revision 2 and further Date: Tue, 5 May 2020 14:37:43 +0200 Message-Id: <20200505123757.39506-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200505123757.39506-1-Jerome.Pouiller@silabs.com> References: <20200505123757.39506-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::27) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by PR3P189CA0022.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20 via Frontend Transport; Tue, 5 May 2020 12:38:11 +0000 X-Mailer: git-send-email 2.26.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ccc18d7c-1497-4030-2bcc-08d7f0f12d20 X-MS-TrafficTypeDiagnostic: MWHPR11MB1824: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-Forefront-PRVS: 0394259C80 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u+YekbkNR/WwYp4Anam3WRL5tpErzLki6T8uWaPZF6Gug7jRaTwyELz6L4nylNHHGi20iKgg5e/FRIzbJnR5adhVjIJU2s+wpdsUhDJY2BxjwxNrSwl8SRvm0DzeVKsen8QDO9UB24xQQX9jK/TwfU44+Vhq+vU3ymgLd59KBpMcd4ZtiWh9xD1KXdo3Wwwb7B6bt/S2B2QW+jXjFgc1CGlMQeNa6wlEoVmR9HqzolOxGKoJZOfeXTEFVbu2KxpQ6RFo+ckkwtfH4ZT6K9hqice4lJgFYmGD2b8Pr/UTGvkuJd/gZKdX35ycyMBxHslkwASdxZPPSyBUa1I60FYxkYgMCN4Cc2AYGJc7PhYNLmfXhF7Iwnstb7D6yf+daCKKMN7OXDLfxW2/DLHk7lZO0AZ9I2D/M1OOOVQffZ46RW5zVKjBI1BV4VSJWx+5WPCGR8k2sL/S22/uOdTiidj3xhgqBWNFFZRC5IEx3b1lEp2h2mtRAAHA1oStHMM9ufBW7R3HEMJPWrACpEU/1Vh8ZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1775.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(396003)(39850400004)(366004)(376002)(346002)(33430700001)(86362001)(6666004)(107886003)(8886007)(1076003)(6512007)(6486002)(66574012)(4744005)(36756003)(5660300002)(2906002)(66476007)(6506007)(16526019)(186003)(52116002)(66946007)(66556008)(54906003)(2616005)(4326008)(8936002)(8676002)(316002)(33440700001)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Gxy/EqGBBFuMgtlxlzCgZoD2V2TcyqCU5ly6t6cNAbT6li+L/mSmwfzROT+8vB7j2PKYEKWl8b1gIktyQR26EVpIXD4Cuad78f4A+MpUvLHae7xbSN8tl5i3YgnaAzaLu9Ic61K2Cj09buLguzGmAWGtJTVzb1V5KjjWFP9IzE9swgxcoM5d5qbXtdfwG2Gm76ucJwFbZBfjRueEOTtgGNub8qhctoL1CDR3kRLqO1+PdXSc3ji1Kaz2AlosJZsZ+FaKQgpkSajigdINwa8Xl92WncKM6A0kpfKO3GCMxXGYIPVY4xHGuhOMyg91P1kWlJBoZd2h+iSYnQSVnb0Jq3QcMlyc9vbKYToNs2/OGHtVxg+7ylqp3/Xvn0oK3tx0MUXPYMqf5n7dglIrqH2P2toNwfQGE2NBZbQT++/FT+nIjlOIigilclusG0u8r+ZaxmJCLcEuaIPtItnY/0a0+VxdRyCrRzoXjjd59Q63YvEwgzZvS/PeZSP0mSrqlLdRaACcQpL8zFhepPkQEkUeU4iXoMyc2B7DPR5FbW4KYdXEBYS5WLSEqhwUGwWp9KvBD0HW1Do4XMFS3NO4KUplB9NJLY6gMq5SAgdWbZnpUy6lgFQ3UlIka9b9RFTgoiENPJBV87gCCKaAwvHWgvJFHFbyVITssdo1KljKjyBCtOJvw0A9kpxTQDRZj9aTRoIgqKT9Za0mjpRvKpSMsSG6eFfdaKu5JGo2+t6IZPZYbJAhz2Q/ItoiGTwHf3/4M5JKFqVvFScf9nmGyDaxcC/8P/Xl+DjpJLQKiNdjI/11B/R8GDs9DzxVoNagIiZBTVdiyVSeXmHqbxKBH173vknUNycXmHdUy3+xdTqv/YH5F2w= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ccc18d7c-1497-4030-2bcc-08d7f0f12d20 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2020 12:38:13.5980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ihUWIp8X/qkyMMYDWIVtVlyD+6MH92CO2bj5FidEwW/pR89zbqweMgRd2toGUIuWI2/Hi+9qfwGYRIQiSDMr0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1824 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Currently, the driver explicitly exclude support for chip with version number it does not know. However, it unlikely that any futur hardware change would break the driver. Therefore, we prefer to invert the test and only exclude the versions we know the driver does not support. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/fwio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c index 9d61082c1e6c..e2f914296677 100644 --- a/drivers/staging/wfx/fwio.c +++ b/drivers/staging/wfx/fwio.c @@ -360,7 +360,7 @@ int wfx_init_device(struct wfx_dev *wdev) dev_dbg(wdev->dev, "initial config register value: %08x\n", reg); hw_revision = FIELD_GET(CFG_DEVICE_ID_MAJOR, reg); - if (hw_revision == 0 || hw_revision > 2) { + if (hw_revision == 0) { dev_err(wdev->dev, "bad hardware revision number: %d\n", hw_revision); return -ENODEV;