From patchwork Fri Apr 10 13:32:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 221282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3415DC2BB86 for ; Fri, 10 Apr 2020 13:34:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D2D520673 for ; Fri, 10 Apr 2020 13:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="NYUfbvJe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbgDJNdY (ORCPT ); Fri, 10 Apr 2020 09:33:24 -0400 Received: from mail-bn8nam12on2076.outbound.protection.outlook.com ([40.107.237.76]:32790 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726817AbgDJNdW (ORCPT ); Fri, 10 Apr 2020 09:33:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e45X+I9InV3K9ZuJIfuvX/0mMTQWB+TjJvFL/IHIopXjS/zykl+/mw+7OL6Y30k2czlSNQTNOcbkw8bWNLF/BqmtTCEQ5LfcMzb2c1NNYIiQVEBHwSmgGyGCyx1DqUzAnjr9hnZBoJbNls2L18pSvDFRPnyBJyhJSPQuculWkX2g2tnKBWthN+Ato76fBecW6zB0PE6SpyAWGKmkITcN9lRyQ2rDHTrJrWON6qEIDjjTQbSgj5hvfoCae2tY+OGsYZeYTMcKprtVsIpse527uPWJ7sr63vuqt+m1v83hRjvSNwkenpvfU7G5rAy6dJdUyKjYxkl7/NxWoqKcsliblg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJTAQ/VR5u4yLmSor5pc09/mMk/uKUBfJs00iVDEZYw=; b=IKOS5hlWwc5/Yn/xEFqAQG4dcFZIwrC+P5G5tkS3Y6DSx0GcFs/+EWU0xG83DZ+gb1T+6M5VgeSdVlzf2WdgA1F0smtDN449050y0nVKR9IBKQsaPAWCWI4jZrdE7+oz/BWKcNBR6hRZVUT11fl/MuZxDhBP2y4Q4YehlhW8LqIsPBWo3Wqz6MphsgHnwfCXyzB1SSrNY7u10BC2sgEDA5UnfVv5KkqcdfNTc8T8P87f+vhsbDEY516M3FjCv59yQww5bte1e/GeEvEL35+qOFQfgC2a3mvoc6DRkO+scJLPzQMXjDCYy5xwezMzYg6B+QnsPqrXNF0uHLsWpknMCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fJTAQ/VR5u4yLmSor5pc09/mMk/uKUBfJs00iVDEZYw=; b=NYUfbvJef0Z7+J4XiTcfkWk/vXtlqXdG1VL+7azzWte3hWew+J40n7Ei7S2CExnFjsOtZFPkCreM7D8MBctrl8X59chFQg0HxKGcPy/I7NgbrC4gwBKH/Z22nnFpt7Me4Q/hojvvATyL6FaqFAYRaxMf0ZSAVTm4AqxoYIg9hTo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4333.namprd11.prod.outlook.com (2603:10b6:208:195::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Fri, 10 Apr 2020 13:33:16 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:16 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 09/19] staging: wfx: disabling keep alive during unjoin is useless Date: Fri, 10 Apr 2020 15:32:29 +0200 Message-Id: <20200410133239.438347-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:14 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55584d7a-ddd4-4589-c2ab-08d7dd53b966 X-MS-TrafficTypeDiagnostic: MN2PR11MB4333: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:193; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(346002)(376002)(136003)(366004)(39850400004)(396003)(2616005)(107886003)(86362001)(316002)(4326008)(8676002)(81156014)(36756003)(52116002)(7696005)(8936002)(478600001)(6486002)(2906002)(66946007)(186003)(66556008)(16526019)(66574012)(5660300002)(1076003)(66476007)(6666004)(4744005)(54906003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ru0fzvK4rAAZVCuCbCQKxWwz55m99BoQrYzUgxNrMKurKKbQKb/R0W/XwesI0pwcyDSojprxEi5TeGj85GU+EtB2PZBTnRtvKpdOXLVPSeexVaBOfFY/HaQeVo3K9BrEugv6FkpNmx8OvjD/xzz49nvTA0MCtFIkCqgvIo/pXnsnjElF7PFPTGvhQQ6v1tdWIOz4JcqJKI7KlsJv0U9CEnHRqaF5wfpTYCNb/IOrGLQPBe0qd3J31BCAo9CyBVmSUkPGRgYpU5dgTqSMtLAeUQfANzEA3dLWtv0DD+LQKleoAVBiwUocHpHBE+cguiWHY8zLtTZtWbwJHmAmIV663NObgyKuNe2Tdg3HMLNdjWMCaiV/vYtaFnNikaVLE0023WAFy7uGGdWt8UFxm/AFk+0OjSdd0F+DF/NsTVvskPZy0ZXUp98GVwnOGHEriyN7 X-MS-Exchange-AntiSpam-MessageData: TKVmW8jLIsHP69lcPzZswanDuQ01Pzvg4O6kXtZJFdig8vPH+TVeCSEhgJF1QhH7vkCsENRz6sqpbVb4bM+2NwhZdd8iY9S+xb7KVFSq6TTZelqZWOz3BsAvvwQ8AS2At2zGXGmiyZZ1RdbcEfx7o0akvqUTAbofBPPfhw19NMN2DMXeGg3467hfrWsUoIDNhxy8+fgv6ngB3uH9t5pY0w== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55584d7a-ddd4-4589-c2ab-08d7dd53b966 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:16.1636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tVs4MvFhCBEjN9vu1XjeETFAh+VWY6Uab1RmmaeNlRWxEu8H1wC13BaP+luZiZyAOwE+YmEeQp8sB3T/U5bVbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4333 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller After a call to hif_reset(), the parameters associated with BSS are reset. So, it useless to explicitly reset the keep alive period. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 67e16c435848..b0557dab91fd 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -413,7 +413,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) /* Unjoin is a reset. */ wfx_tx_lock_flush(wvif->wdev); - hif_keep_alive_period(wvif, 0); hif_reset(wvif, false); wfx_tx_policy_init(wvif); hif_set_macaddr(wvif, wvif->vif->addr);