From patchwork Fri Apr 10 13:32:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 221285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B48C2BB1D for ; Fri, 10 Apr 2020 13:34:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C337B20CC7 for ; Fri, 10 Apr 2020 13:34:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="HcpVaOGi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727109AbgDJNd5 (ORCPT ); Fri, 10 Apr 2020 09:33:57 -0400 Received: from mail-dm6nam12on2089.outbound.protection.outlook.com ([40.107.243.89]:6130 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726953AbgDJNdj (ORCPT ); Fri, 10 Apr 2020 09:33:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OU6rCrCKygu/5TAzGYa1CD8iqOvXC49k2UZkCETmgXqNGnI5XhEnUfZizCf4gpm2cOehFwgjAxjRGNZBi6qrsn0ZbpOsHMx+enimYCsDM17Vt+vNbTOUPaxys4QR0+F3X4FuinHFL7d4HJuHItN/L9abex1gxbma4JZVqmPD0TQzZyZiWrYFwo2DQu+tgDb8eyOSFNWHC702hb8W/xAShA0+xBUgydyxbACbAXwu1P5h1uKClUVr1XxH+YXUW1AmLke1nGq1kEuUpZe5+CpPNeBKV/lQ9wtTvHUgMDy8o+HvX7nUCgLbOTro8l9jmTz87MxD9w9ThkKuevNAYYeqfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j1WN53AH335kYeRtxLb+77TvAaP2Hkl2lY88WHoq8+M=; b=KDa/9hN2z2LXKypPNbzyYEG8qddom1mxWz7ro7Wt3HAtQFquQEwOkW4PxcviuD5Le6AFbom3hSHFDxbveHlq7kEt37vPgcScZyodXqUsDRuwPd5jWBJsC8VlQtli49iaVYZcSoMgNPo/AlKKbPR3c+pqFrjSNxkY3mBUm5znC3JptpOY9DOAdjz8nH1J6a7Nc/UJzYqFlGJ1XbFp33kRIXVd3SPr1DCDAn9nkJh+RTCE2/YkTgGDfk+ufgTe2Z83o20/i42Bsoj1a3zWEiNbFfiW/3mXe6hxgVf8Knb75nwcPHGbhiEQeGeCXeHecJ116VbBNLkh7KV/XcSKi5k/3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j1WN53AH335kYeRtxLb+77TvAaP2Hkl2lY88WHoq8+M=; b=HcpVaOGiCp/v704OE5Dn4nqj5tFub+l57pNU6UnBMFXMEAZPZz+HzxxcZma1e477uyyTVHsZ76eVQxYe+TcdAg6x5ZRWCoI9s6P1LcfIhfUd9+JWU8QIJx58lBCTDF8/D2QoyghYKl3b+2nuYHCTZLbDHNPgizRhUtSWgnIj4SE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4398.namprd11.prod.outlook.com (2603:10b6:208:18b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.20; Fri, 10 Apr 2020 13:33:31 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::3d0a:d9ac:3df4:8b1%6]) with mapi id 15.20.2878.021; Fri, 10 Apr 2020 13:33:31 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 17/19] staging: wfx: check value of beacon_int Date: Fri, 10 Apr 2020 15:32:37 +0200 Message-Id: <20200410133239.438347-18-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> References: <20200410133239.438347-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by DM5PR15CA0056.namprd15.prod.outlook.com (2603:10b6:3:ae::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Fri, 10 Apr 2020 13:33:29 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1055b76-ca35-4992-c4f8-08d7dd53c269 X-MS-TrafficTypeDiagnostic: MN2PR11MB4398: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-Forefront-PRVS: 0369E8196C X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(366004)(346002)(396003)(136003)(39850400004)(376002)(107886003)(81156014)(54906003)(8676002)(86362001)(1076003)(6666004)(8936002)(4326008)(52116002)(7696005)(316002)(66556008)(66946007)(186003)(478600001)(2906002)(6486002)(2616005)(66476007)(16526019)(5660300002)(36756003); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EJur2XXEvFQuxt0Yv13icWotaVeMJ1ixRpCLNvyU+ZxYgeN3AKTLYWbOHbYffy4SEtCoPSLthahBCJS9O+7jvphlA/p3s4aHFVQHfQCjzMTJpplgKUmrc5PPHFFpLMCREEO3wKba/lDndFUNvYwvdZStyXTE/SwtGmg5VDCFUZQYgSubWqT+CsEUpnyxhYJdGLTa6oNVhE8CqfEv9z4eVYhXzjrZF7MB7ubuis3vi+8+1jc5nBd68LPXd9A2wowcvStADkKqHXS6DW9+fGPyYB6Uv2WrANhRTCIQqk9buuFhzmFKpv7RyD1HF5+VqqDO/7c6W/oxwudRI/GzR1XKggoyA5DxmPBVNczZYn2ZkhM7lLAEDnYUWu/ft/BgLUZ67jqq7YzgCNqJz8Q2makFomaTrp0ni22RTNYuHkEHghFnw/f2EpC+BAnVDl7u5KnZ X-MS-Exchange-AntiSpam-MessageData: sAvH7PhvHNVpCeTTQTEDJ8ScsadwreLBWX+PE1qox2c7kM4GTTBf8i3Fmyq6YdEeCBVIBollM6mKb9dNojP9SHzAIyN5I5Zoqfmws1v2sR/dpetGz7ceW91n7MyPELy28wkXXUNArlLgzpRcyq0HmeEFx/mGt5x+fH3AMRRe1S6QAygDWJiKq10rJQslir3W3f4FbsVgE2okOhz7E4f4lQ== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1055b76-ca35-4992-c4f8-08d7dd53c269 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2020 13:33:31.3168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dZAB+ltIwXCe0PPysfEYfMRQ/n9f8Uf0o/FyogzWyXbwZmucujqYzGVW1W41b+/oYjilFD10Pd1saMrxY7hiIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4398 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Firmware dislike when beacon_int value is 0. This patch add some warnings in case it would happen. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index d44e5cacbbce..f49ab67e1a6d 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -296,6 +296,7 @@ int hif_join(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf, struct hif_msg *hif; struct hif_req_join *body = wfx_alloc_hif(sizeof(*body), &hif); + WARN_ON(!conf->beacon_int); WARN_ON(!conf->basic_rates); WARN_ON(sizeof(body->ssid) < ssidlen); WARN(!conf->ibss_joined && !ssidlen, "joining an unknown BSS"); @@ -430,6 +431,7 @@ int hif_start(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf, struct hif_msg *hif; struct hif_req_start *body = wfx_alloc_hif(sizeof(*body), &hif); + WARN_ON(!conf->beacon_int); body->dtim_period = conf->dtim_period; body->short_preamble = conf->use_short_preamble; body->channel_number = cpu_to_le16(channel->hw_value);