[10/19] staging: wfx: drop unnecessary condition checks in wfx_upload_ap_templates()

Message ID 20200410133239.438347-11-Jerome.Pouiller@silabs.com
State New
Headers show
  • staging: wfx: simplify start/shutdown of RF
Related show

Commit Message

Jerome Pouiller April 10, 2020, 1:32 p.m.
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

In former code, wfx_upload_ap_templates() was called in more cases
than necessary. Therefore, it tried to not update the frame templates
if it was not necessary.

Now, wfx_upload_ap_templates() is called only if mac80211 asked to
update the templates. In add, it does not hurt to upload template if
they are not used. So, remove unnecessary conditions at beginning of

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
 drivers/staging/wfx/sta.c | 5 -----
 1 file changed, 5 deletions(-)


diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index b0557dab91fd..7af7bfa4ac99 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -570,11 +570,6 @@  static int wfx_upload_ap_templates(struct wfx_vif *wvif)
 	struct sk_buff *skb;
-	if (wvif->vif->type == NL80211_IFTYPE_STATION ||
-	    wvif->vif->type == NL80211_IFTYPE_MONITOR ||
-	    wvif->vif->type == NL80211_IFTYPE_UNSPECIFIED)
-		return 0;
 	skb = ieee80211_beacon_get(wvif->wdev->hw, wvif->vif);
 	if (!skb)
 		return -ENOMEM;