[05/19] staging: wfx: set all parameters before starting AP

Message ID 20200410133239.438347-6-Jerome.Pouiller@silabs.com
State New
Headers show
Series
  • staging: wfx: simplify start/shutdown of RF
Related show

Commit Message

Jerome Pouiller April 10, 2020, 1:32 p.m.
From: Jérôme Pouiller <jerome.pouiller@silabs.com>

Current code start AP and then configure the different parameters. Since
all the configuration is sent quickly after AP started, it works.
However, it is not very nice. In add, last firmware releases start to
disallow incorrect settings.

Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
---
 drivers/staging/wfx/sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
index 92bf317b57bb..1e7ff2ba33d8 100644
--- a/drivers/staging/wfx/sta.c
+++ b/drivers/staging/wfx/sta.c
@@ -604,7 +604,6 @@  int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 {
 	struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv;
 
-	hif_start(wvif, &vif->bss_conf, wvif->channel);
 	wfx_upload_keys(wvif);
 	if (wvif_count(wvif->wdev) <= 1)
 		hif_set_block_ack_policy(wvif, 0xFF, 0xFF);
@@ -612,6 +611,7 @@  int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 	wfx_update_filtering(wvif);
 	wfx_upload_ap_templates(wvif);
 	wfx_fwd_probe_req(wvif, false);
+	hif_start(wvif, &vif->bss_conf, wvif->channel);
 	return 0;
 }