[04/28] netfilter: nf_tables: fix double-free on set expression from the error path

Message ID 20200330192136.230459-5-pablo@netfilter.org
State Superseded
Headers show
  • Untitled series #42551
Related show

Commit Message

Pablo Neira Ayuso March 30, 2020, 7:21 p.m.
After copying the expression to the set element extension, release the
expression and reset the pointer to avoid a double-free from the error

Fixes: 409444522976 ("netfilter: nf_tables: add elements with stateful expressions")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
 net/netfilter/nf_tables_api.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index f1910cd795fd..29ad33e52dbb 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -5133,6 +5133,7 @@  static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
 	if (expr) {
 		memcpy(nft_set_ext_expr(ext), expr, expr->ops->size);
+		expr = NULL;
 	trans = nft_trans_elem_alloc(ctx, NFT_MSG_NEWSETELEM, set);