[V1,net,2/7] net: ena: avoid unnecessary admin command when RSS function set fails

Message ID 1584362304-274-3-git-send-email-akiyano@amazon.com
State New
Headers show
  • [V1,net,1/7] net: ena: fix incorrect setting of the number of msix vectors
Related show

Commit Message

Kiyanovski, Arthur March 16, 2020, 12:38 p.m.
From: Arthur Kiyanovski <akiyano@amazon.com>

Currently when ena_set_hash_function() fails the hash function is
restored to the previous value by calling an admin command to get
the hash function from the device.

In this commit we avoid the admin command, by saving the previous
hash function before calling ena_set_hash_function() and using this
previous value to restore the hash function in case of failure of

Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
 drivers/net/ethernet/amazon/ena/ena_com.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 1fb58f9ad80b..e648773e3d11 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -2290,6 +2290,7 @@  int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,
 	struct ena_admin_get_feat_resp get_resp;
 	struct ena_admin_feature_rss_flow_hash_control *hash_key =
+	enum ena_admin_hash_functions old_func;
 	int rc;
 	/* Make sure size is a mult of DWs */
@@ -2329,12 +2330,13 @@  int ena_com_fill_hash_function(struct ena_com_dev *ena_dev,
 		return -EINVAL;
+	old_func = rss->hash_func;
 	rss->hash_func = func;
 	rc = ena_com_set_hash_function(ena_dev);
 	/* Restore the old function */
 	if (unlikely(rc))
-		ena_com_get_hash_function(ena_dev, NULL, NULL);
+		rss->hash_func = old_func;
 	return rc;