RFR: Missing as_Register() in cmpLTMask_reg_reg

Message ID 1386871406.26061.4.camel@localhost.localdomain
State New
Headers show

Commit Message

Edward Nevill Dec. 12, 2013, 6:03 p.m.
Hi,

JTReg test compiler/7048332/Test7048332 fails with C2 because it generates

cmp Rp, #q

instead of 

cmp Rp, Rq

Fixed as follows,

OK to push,
Ed.

--- CUT HERE ---
exporting patch:
# HG changeset patch
# User Edward Nevill edward.nevill@linaro.org
# Date 1386871109 0
#      Thu Dec 12 17:58:29 2013 +0000
# Node ID 390889cee20523b8bf400433ac171654893c3702
# Parent  36ec6f5b872338684a26d353b77d7b747558281d
Missing as_Register() in cmpLTMask_reg_reg

Comments

Andrew Haley Dec. 12, 2013, 6:21 p.m. | #1
On 12/12/2013 06:03 PM, Edward Nevill wrote:
> OK to push,

Oops.  :)   Yes, please.

Andrew.

Patch

diff -r 36ec6f5b8723 -r 390889cee205 src/cpu/aarch64/vm/aarch64.ad
--- a/src/cpu/aarch64/vm/aarch64.ad	Thu Dec 12 12:50:55 2013 +0000
+++ b/src/cpu/aarch64/vm/aarch64.ad	Thu Dec 12 17:58:29 2013 +0000
@@ -10489,7 +10489,7 @@ 
   %}
 
   ins_encode %{
-    __ cmpw(as_Register($p$$reg), $q$$reg);
+    __ cmpw(as_Register($p$$reg), as_Register($q$$reg));
     __ csetw(as_Register($dst$$reg), Assembler::LT);
     __ subw(as_Register($dst$$reg), zr, as_Register($dst$$reg));
   %}
--- CUT HERE ---