From patchwork Thu Dec 12 18:03:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Nevill X-Patchwork-Id: 22301 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f198.google.com (mail-ve0-f198.google.com [209.85.128.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2F23523FC7 for ; Thu, 12 Dec 2013 18:03:30 +0000 (UTC) Received: by mail-ve0-f198.google.com with SMTP id oy12sf1602205veb.5 for ; Thu, 12 Dec 2013 10:03:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:subject:from:reply-to:to :cc:date:organization:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=kXGnU2gAoQcew2IbLPKvsGCOTCoXXBDxpxC9yTUCD+4=; b=GmI3Jl4rgVVB7GVHoa/Ztsq8CfwAA4P62AE3KOSGxZ8s5xhVVcg8gz7Tz4hHMvZRbG KhgfaC4+Yk5m9Enec0to3J6UsqOzaAV13nqhmPTBYqt+bVd+vAFNf31Gy/iWvz0YL6eX LIJeDy6Bby5mDNYjBDQkW3qeioZldb2m24rKc55wNtiaw2MPz3rkNJtsKELtcr9Lakxp zxyZnT0CPA3KeuWFgDMJ9Zl+Rx8eXlGqKuUw4xZlpTbs6+Mz37+3EXc8XXQM9VVD9PUC yXraIzGdjqM2bZExjDWlLl9Z9+2pqKRpRHt2tb03ycVZ54B162jfgXRtukTmwvARgg9a vznw== X-Gm-Message-State: ALoCoQkG92B34OA4G01Vqewy3G3D98DSgI/1KpOcWsrztdmchI27JdQF9YMF/V5agdT24Tl5z5oZ X-Received: by 10.58.94.162 with SMTP id dd2mr3732940veb.21.1386871410362; Thu, 12 Dec 2013 10:03:30 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.2.41 with SMTP id 9ls626380qer.99.gmail; Thu, 12 Dec 2013 10:03:30 -0800 (PST) X-Received: by 10.52.22.40 with SMTP id a8mr333934vdf.49.1386871410206; Thu, 12 Dec 2013 10:03:30 -0800 (PST) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id y9si7977709vcn.3.2013.12.12.10.03.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Dec 2013 10:03:30 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id ie18so542007vcb.38 for ; Thu, 12 Dec 2013 10:03:30 -0800 (PST) X-Received: by 10.220.200.65 with SMTP id ev1mr4559759vcb.13.1386871409995; Thu, 12 Dec 2013 10:03:29 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp375360vcz; Thu, 12 Dec 2013 10:03:29 -0800 (PST) X-Received: by 10.180.92.230 with SMTP id cp6mr4005598wib.0.1386871409143; Thu, 12 Dec 2013 10:03:29 -0800 (PST) Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by mx.google.com with ESMTPS id e6si4864123wik.35.2013.12.12.10.03.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 12 Dec 2013 10:03:29 -0800 (PST) Received-SPF: neutral (google.com: 209.85.212.175 is neither permitted nor denied by best guess record for domain of edward.nevill@linaro.org) client-ip=209.85.212.175; Received: by mail-wi0-f175.google.com with SMTP id hi5so9104481wib.2 for ; Thu, 12 Dec 2013 10:03:28 -0800 (PST) X-Received: by 10.180.24.193 with SMTP id w1mr10323241wif.44.1386871408585; Thu, 12 Dec 2013 10:03:28 -0800 (PST) Received: from [192.168.1.112] ([213.122.173.130]) by mx.google.com with ESMTPSA id cx3sm7120165wib.0.2013.12.12.10.03.26 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 12 Dec 2013 10:03:27 -0800 (PST) Message-ID: <1386871406.26061.4.camel@localhost.localdomain> Subject: RFR: Missing as_Register() in cmpLTMask_reg_reg From: Edward Nevill Reply-To: edward.nevill@linaro.org To: "aarch64-port-dev@openjdk.java.net" Cc: patches@linaro.org Date: Thu, 12 Dec 2013 18:03:26 +0000 Organization: Linaro X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) Mime-Version: 1.0 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: edward.nevill@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi, JTReg test compiler/7048332/Test7048332 fails with C2 because it generates cmp Rp, #q instead of cmp Rp, Rq Fixed as follows, OK to push, Ed. --- CUT HERE --- exporting patch: # HG changeset patch # User Edward Nevill edward.nevill@linaro.org # Date 1386871109 0 # Thu Dec 12 17:58:29 2013 +0000 # Node ID 390889cee20523b8bf400433ac171654893c3702 # Parent 36ec6f5b872338684a26d353b77d7b747558281d Missing as_Register() in cmpLTMask_reg_reg diff -r 36ec6f5b8723 -r 390889cee205 src/cpu/aarch64/vm/aarch64.ad --- a/src/cpu/aarch64/vm/aarch64.ad Thu Dec 12 12:50:55 2013 +0000 +++ b/src/cpu/aarch64/vm/aarch64.ad Thu Dec 12 17:58:29 2013 +0000 @@ -10489,7 +10489,7 @@ %} ins_encode %{ - __ cmpw(as_Register($p$$reg), $q$$reg); + __ cmpw(as_Register($p$$reg), as_Register($q$$reg)); __ csetw(as_Register($dst$$reg), Assembler::LT); __ subw(as_Register($dst$$reg), zr, as_Register($dst$$reg)); %} --- CUT HERE ---