[4.9,057/128] net: ena: fix error returning in ena_com_get_hash_function()

Message ID 20200619141623.209016168@linuxfoundation.org
State Superseded
Headers show
  • Untitled series #28329
Related show

Commit Message

Greg Kroah-Hartman June 19, 2020, 2:32 p.m.
From: Arthur Kiyanovski <akiyano@amazon.com>

[ Upstream commit e9a1de378dd46375f9abfd8de1e6f59ee114a793 ]

In case the "func" parameter is NULL we now return "-EINVAL".
This shouldn't happen in general, but when it does happen, this is the
proper way to handle it.

We also check func for NULL in the beginning of the function, as there
is no reason to do all the work and realize in the end of the function
it was useless.

Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
 drivers/net/ethernet/amazon/ena/ena_com.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 905911f78693..e95f19e573a7 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -2096,6 +2096,9 @@  int ena_com_get_hash_function(struct ena_com_dev *ena_dev,
 	int rc;
+	if (unlikely(!func))
+		return -EINVAL;
 	rc = ena_com_get_feature_ex(ena_dev, &get_resp,
@@ -2108,8 +2111,7 @@  int ena_com_get_hash_function(struct ena_com_dev *ena_dev,
 	if (rss->hash_func)
-	if (func)
-		*func = rss->hash_func;
+	*func = rss->hash_func;
 	if (key)
 		memcpy(key, hash_key->key, (size_t)(hash_key->keys_num) << 2);