From patchwork Fri Dec 27 05:07:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 22753 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D233920540 for ; Fri, 27 Dec 2013 05:10:59 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id tp5sf40772862ieb.5 for ; Thu, 26 Dec 2013 21:10:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=lYLuSzkXMgyB7Rcshf2ekjhCDa8o0pAw/znnC/jRdlc=; b=LsN1R+A1/pJtUgVYN3te3lbojXtnmXPKoOdUuvsNH5W1y1xO4fXgChzMfbS7BoOFgj /NUMMX3swawylXQHjOUncBXZrUhht+O0OppbLpubDrCO72jY9A4nA5qsLJ2EUal8lMUc hmHwfQ8t1laG/sFWGqiwT2bpEDVHiZfYg26UXzCRKxcWUqHVbsPaSbQTwidHX2lI0Q8T vHnVvDL1+SzAgABU/W1HUn0ecVNKPAeYHXwN6CATGvS7erRlSz0qeNUjxYYIg0asQ2Ih JiQDuOojSMdzDk9EsLwMnfEetgqkbLq4CrSPp+xQnc9Sm0a/n77PDYjseP/25eBRROfD Ic+Q== X-Gm-Message-State: ALoCoQmqmM1zck3chy8NaVACr5/vtQQaUqcOhqLhGfr3SLcKVksolxSDsAF7JnPUnovINgSYmK3n X-Received: by 10.42.194.5 with SMTP id dw5mr16110584icb.5.1388121058814; Thu, 26 Dec 2013 21:10:58 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.17.65 with SMTP id m1ls2735049qed.91.gmail; Thu, 26 Dec 2013 21:10:58 -0800 (PST) X-Received: by 10.220.175.16 with SMTP id v16mr88751vcz.72.1388121058710; Thu, 26 Dec 2013 21:10:58 -0800 (PST) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id pu5si9756854veb.135.2013.12.26.21.10.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Dec 2013 21:10:58 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id ij19so4616361vcb.31 for ; Thu, 26 Dec 2013 21:10:58 -0800 (PST) X-Received: by 10.58.146.5 with SMTP id sy5mr2987862veb.43.1388121058627; Thu, 26 Dec 2013 21:10:58 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.59.13.131 with SMTP id ey3csp435864ved; Thu, 26 Dec 2013 21:10:58 -0800 (PST) X-Received: by 10.68.12.138 with SMTP id y10mr48518091pbb.101.1388121057551; Thu, 26 Dec 2013 21:10:57 -0800 (PST) Received: from mail-pb0-f47.google.com (mail-pb0-f47.google.com [209.85.160.47]) by mx.google.com with ESMTPS id r7si23018872pbk.147.2013.12.26.21.10.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Dec 2013 21:10:57 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.47 is neither permitted nor denied by best guess record for domain of tushar.behera@linaro.org) client-ip=209.85.160.47; Received: by mail-pb0-f47.google.com with SMTP id um1so8789236pbc.6 for ; Thu, 26 Dec 2013 21:10:57 -0800 (PST) X-Received: by 10.66.174.165 with SMTP id bt5mr7485274pac.151.1388121057156; Thu, 26 Dec 2013 21:10:57 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id tu3sm15722968pab.1.2013.12.26.21.10.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 26 Dec 2013 21:10:56 -0800 (PST) From: Tushar Behera To: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jslaby@suse.cz, gregkh@linuxfoundation.org, patches@linaro.org Subject: [PATCH] serial: samsung: Remove hard-coded major/minor numbers Date: Fri, 27 Dec 2013 10:37:28 +0530 Message-Id: <1388120848-15879-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: tushar.behera@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The hard-coded values clash with the values set for amba-pl011 serial driver. Because of this there is no serial output on Samsung boards if amba-pl011 is enabled alongwith samsung-serial driver. Remove the hardcoded values and let the framework decide on appropriate major/minor number. This is required for multi-platform development work on Exynos platform. Signed-off-by: Tushar Behera --- drivers/tty/serial/samsung.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index c1af04d..9c20543 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -56,8 +56,6 @@ /* UART name and device definitions */ #define S3C24XX_SERIAL_NAME "ttySAC" -#define S3C24XX_SERIAL_MAJOR 204 -#define S3C24XX_SERIAL_MINOR 64 /* macros to change one thing to another */ @@ -951,8 +949,6 @@ static struct uart_driver s3c24xx_uart_drv = { .nr = CONFIG_SERIAL_SAMSUNG_UARTS, .cons = S3C24XX_SERIAL_CONSOLE, .dev_name = S3C24XX_SERIAL_NAME, - .major = S3C24XX_SERIAL_MAJOR, - .minor = S3C24XX_SERIAL_MINOR, }; static struct s3c24xx_uart_port s3c24xx_serial_ports[CONFIG_SERIAL_SAMSUNG_UARTS] = {