[Xen-devel,OSSTEST] standalone: Correct arguments to JobDB flight_create

Message ID 1390322740-961-1-git-send-email-ian.campbell@citrix.com
State New
Headers show

Commit Message

Ian Campbell Jan. 21, 2014, 4:45 p.m.
The real jobdb takes $intended and $branch in the other order, meaningthat the
standalone db ends up with them backwards.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 Osstest/JobDB/Standalone.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ian Campbell Jan. 22, 2014, 10:02 a.m. | #1
On Tue, 2014-01-21 at 16:47 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] standalone: Correct arguments to JobDB flight_create"):
> > The real jobdb takes $intended and $branch in the other order, meaningthat the
> > standalone db ends up with them backwards.
> 
> *blrfhl*

Quite! I suppose it doesn't matter mcuh in standalone mode because I
didn't actually see anything in practice, just I manually did 'select
branch frmo flights' and got "play"...

> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Thanks, I've pushed this to pretest.

Ian.

Patch

diff --git a/Osstest/JobDB/Standalone.pm b/Osstest/JobDB/Standalone.pm
index d3ff1df..14293ef 100644
--- a/Osstest/JobDB/Standalone.pm
+++ b/Osstest/JobDB/Standalone.pm
@@ -56,7 +56,7 @@  sub open ($) {
 }
 
 sub flight_create ($$$) {
-    my ($obj, $branch, $intended) = @_;
+    my ($obj, $intended, $branch) = @_;
     my $fl = $ENV{'OSSTEST_FLIGHT'};
     $fl = 'standalone' unless defined $fl && length $fl;
     die "flight names may not contain ." if $fl =~ m/\./;